Summary: | Checkout history in OPAC displaying more than 50 items | ||
---|---|---|---|
Product: | Koha | Reporter: | Sara Brown <sbrown> |
Component: | OPAC | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | Pushed to oldstable --- | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
Severity: | major | ||
Priority: | P5 - low | CC: | fridolin.somers, jonathan.druart, jrobb, martin.renvoize |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Small patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
25.11.00,25.05.02,24.11.08
|
Circulation function: | |
Bug Depends on: | 33949 | ||
Bug Blocks: | 40345 | ||
Attachments: |
Bug 38102: Fix limit to 50 items in the checkout history - OPAC
Bug 38102: Fix default sort order Bug 38102: Fix limit to 50 items in the checkout history - OPAC Bug 38102: Fix default sort order Bug 38102: Fix limit to 50 items in the checkout history - OPAC Bug 38102: Fix default sort order |
Description
Sara Brown
2024-10-04 21:04:16 UTC
Still present in 24.11. I have a patron with a rather large checkout history (3,000+ rows) and this bug seems to be preventing the page from loading for them at all. The limit number is being passed correctly, but it doesn't seem to be doing anything: my $checkouts = [ $patron->checkouts( {}, { order_by => $order, prefetch => { item => { biblio => 'biblioitems' } }, ( $limit ? ( limit => $limit ) : () ), } )->as_list ]; Created attachment 183921 [details] [review] Bug 38102: Fix limit to 50 items in the checkout history - OPAC Checkout history does not limit to 50 items, it's a regression from bug 33949. To limit to 50 items we need to use "rows", not "limit". Test plan: Have more than 50 checkouts and confirm that by default the table only displays 50 entries. Created attachment 183922 [details] [review] Bug 38102: Fix default sort order DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Unknown column 'date_due desc' in 'order clause' at /kohadevbox/koha/Koha/Objects.pm line 401 Created attachment 184206 [details] [review] Bug 38102: Fix limit to 50 items in the checkout history - OPAC Checkout history does not limit to 50 items, it's a regression from bug 33949. To limit to 50 items we need to use "rows", not "limit". Test plan: Have more than 50 checkouts and confirm that by default the table only displays 50 entries. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 184207 [details] [review] Bug 38102: Fix default sort order DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Unknown column 'date_due desc' in 'order clause' at /kohadevbox/koha/Koha/Objects.pm line 401 Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 184321 [details] [review] Bug 38102: Fix limit to 50 items in the checkout history - OPAC Checkout history does not limit to 50 items, it's a regression from bug 33949. To limit to 50 items we need to use "rows", not "limit". Test plan: Have more than 50 checkouts and confirm that by default the table only displays 50 entries. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> Created attachment 184322 [details] [review] Bug 38102: Fix default sort order DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Unknown column 'date_due desc' in 'order clause' at /kohadevbox/koha/Koha/Objects.pm line 401 Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> Nice work everyone! Pushed to main for 25.11 Nice work everyone! Pushed to 25.05.x Pushed to 24.11.x for 24.11.08 |