Bug 40345 - Missing Cypress tests for checkout history - OPAC
Summary: Missing Cypress tests for checkout history - OPAC
Status: Needs Signoff
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 38102 40301 40346
Blocks:
  Show dependency treegraph
 
Reported: 2025-07-11 07:05 UTC by Jonathan Druart
Modified: 2025-07-11 12:16 UTC (History)
0 users

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 40345: Pass a patron to insertSampleCheckout (4.42 KB, patch)
2025-07-11 07:22 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 40345: Add insertSamplePatron (10.62 KB, patch)
2025-07-11 07:22 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 40345: Force checkout (1.40 KB, patch)
2025-07-11 07:22 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 40345: Add tests for bug 38102 (2.46 KB, patch)
2025-07-11 07:22 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 40345: Properly cleanup old checkouts (2.87 KB, patch)
2025-07-11 09:16 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 40345: Pass a patron to insertSampleCheckout (4.42 KB, patch)
2025-07-11 12:16 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 40345: Add insertSamplePatron (10.62 KB, patch)
2025-07-11 12:16 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 40345: Force checkout (1.40 KB, patch)
2025-07-11 12:16 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 40345: Add tests for bug 38102 (2.46 KB, patch)
2025-07-11 12:16 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 40345: Properly cleanup old checkouts (2.87 KB, patch)
2025-07-11 12:16 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 40345: Use then to prevent async issues (3.43 KB, patch)
2025-07-11 12:16 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2025-07-11 07:05:48 UTC
Change from bug 38102 must be covered by tests.
Comment 1 Jonathan Druart 2025-07-11 07:22:29 UTC
Created attachment 183974 [details] [review]
Bug 40345: Pass a patron to insertSampleCheckout

So we won't generate a new patron per checkout
Comment 2 Jonathan Druart 2025-07-11 07:22:31 UTC
Created attachment 183975 [details] [review]
Bug 40345: Add insertSamplePatron

So it's easier to build and insert a new patron
Comment 3 Jonathan Druart 2025-07-11 07:22:33 UTC
Created attachment 183976 [details] [review]
Bug 40345: Force checkout

Pass the confirmation token to force the checkout
Comment 4 Jonathan Druart 2025-07-11 07:22:35 UTC
Created attachment 183977 [details] [review]
Bug 40345: Add tests for bug 38102

Test plan:
  yarn cypress run --spec t/cypress/integration/KohaTable/OPACCirculationHistory_spec.ts
must return green

Revert commits from bug 38102
Run again the Cypress tests
=> They fail
Comment 5 Jonathan Druart 2025-07-11 09:16:28 UTC
Created attachment 183979 [details] [review]
Bug 40345: Properly cleanup old checkouts
Comment 6 Jonathan Druart 2025-07-11 12:16:16 UTC
Created attachment 183983 [details] [review]
Bug 40345: Pass a patron to insertSampleCheckout

So we won't generate a new patron per checkout
Comment 7 Jonathan Druart 2025-07-11 12:16:18 UTC
Created attachment 183984 [details] [review]
Bug 40345: Add insertSamplePatron

So it's easier to build and insert a new patron
Comment 8 Jonathan Druart 2025-07-11 12:16:20 UTC
Created attachment 183985 [details] [review]
Bug 40345: Force checkout

Pass the confirmation token to force the checkout
Comment 9 Jonathan Druart 2025-07-11 12:16:22 UTC
Created attachment 183986 [details] [review]
Bug 40345: Add tests for bug 38102

Test plan:
  yarn cypress run --spec t/cypress/integration/KohaTable/OPACCirculationHistory_spec.ts
must return green

Revert commits from bug 38102
Run again the Cypress tests
=> They fail
Comment 10 Jonathan Druart 2025-07-11 12:16:24 UTC
Created attachment 183987 [details] [review]
Bug 40345: Properly cleanup old checkouts
Comment 11 Jonathan Druart 2025-07-11 12:16:26 UTC
Created attachment 183988 [details] [review]
Bug 40345: Use then to prevent async issues