Bug 40345 - Missing Cypress tests for checkout history - OPAC
Summary: Missing Cypress tests for checkout history - OPAC
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal
Assignee: Jonathan Druart
QA Contact: Martin Renvoize (ashimema)
URL:
Keywords:
Depends on: 38102 40301 40346
Blocks: 40430
  Show dependency treegraph
 
Reported: 2025-07-11 07:05 UTC by Jonathan Druart
Modified: 2025-08-22 08:29 UTC (History)
1 user (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.11.00,25.05.03
Circulation function:


Attachments
Bug 40345: Pass a patron to insertSampleCheckout (4.42 KB, patch)
2025-07-11 07:22 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 40345: Add insertSamplePatron (10.62 KB, patch)
2025-07-11 07:22 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 40345: Force checkout (1.40 KB, patch)
2025-07-11 07:22 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 40345: Add tests for bug 38102 (2.46 KB, patch)
2025-07-11 07:22 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 40345: Properly cleanup old checkouts (2.87 KB, patch)
2025-07-11 09:16 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 40345: Pass a patron to insertSampleCheckout (4.42 KB, patch)
2025-07-11 12:16 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 40345: Add insertSamplePatron (10.62 KB, patch)
2025-07-11 12:16 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 40345: Force checkout (1.40 KB, patch)
2025-07-11 12:16 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 40345: Add tests for bug 38102 (2.46 KB, patch)
2025-07-11 12:16 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 40345: Properly cleanup old checkouts (2.87 KB, patch)
2025-07-11 12:16 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 40345: Use then to prevent async issues (3.43 KB, patch)
2025-07-11 12:16 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 40345: Pass a patron to insertSampleCheckout (4.47 KB, patch)
2025-07-17 16:44 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 40345: Add insertSamplePatron (10.67 KB, patch)
2025-07-17 16:44 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 40345: Force checkout (1.45 KB, patch)
2025-07-17 16:44 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 40345: Add tests for bug 38102 (2.51 KB, patch)
2025-07-17 16:44 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 40345: Properly cleanup old checkouts (2.92 KB, patch)
2025-07-17 16:44 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 40345: Use then to prevent async issues (3.48 KB, patch)
2025-07-17 16:44 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 40345: Pass a patron to insertSampleCheckout (4.53 KB, patch)
2025-07-18 11:27 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 40345: Add insertSamplePatron (10.73 KB, patch)
2025-07-18 11:27 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 40345: Force checkout (1.52 KB, patch)
2025-07-18 11:27 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 40345: Add tests for bug 38102 (2.57 KB, patch)
2025-07-18 11:28 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 40345: Properly cleanup old checkouts (2.99 KB, patch)
2025-07-18 11:28 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 40345: Use then to prevent async issues (3.54 KB, patch)
2025-07-18 11:28 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2025-07-11 07:05:48 UTC
Change from bug 38102 must be covered by tests.
Comment 1 Jonathan Druart 2025-07-11 07:22:29 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2025-07-11 07:22:31 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2025-07-11 07:22:33 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2025-07-11 07:22:35 UTC Comment hidden (obsolete)
Comment 5 Jonathan Druart 2025-07-11 09:16:28 UTC Comment hidden (obsolete)
Comment 6 Jonathan Druart 2025-07-11 12:16:16 UTC
Created attachment 183983 [details] [review]
Bug 40345: Pass a patron to insertSampleCheckout

So we won't generate a new patron per checkout
Comment 7 Jonathan Druart 2025-07-11 12:16:18 UTC
Created attachment 183984 [details] [review]
Bug 40345: Add insertSamplePatron

So it's easier to build and insert a new patron
Comment 8 Jonathan Druart 2025-07-11 12:16:20 UTC
Created attachment 183985 [details] [review]
Bug 40345: Force checkout

Pass the confirmation token to force the checkout
Comment 9 Jonathan Druart 2025-07-11 12:16:22 UTC
Created attachment 183986 [details] [review]
Bug 40345: Add tests for bug 38102

Test plan:
  yarn cypress run --spec t/cypress/integration/KohaTable/OPACCirculationHistory_spec.ts
must return green

Revert commits from bug 38102
Run again the Cypress tests
=> They fail
Comment 10 Jonathan Druart 2025-07-11 12:16:24 UTC
Created attachment 183987 [details] [review]
Bug 40345: Properly cleanup old checkouts
Comment 11 Jonathan Druart 2025-07-11 12:16:26 UTC
Created attachment 183988 [details] [review]
Bug 40345: Use then to prevent async issues
Comment 12 Owen Leonard 2025-07-17 16:44:36 UTC
Created attachment 184230 [details] [review]
Bug 40345: Pass a patron to insertSampleCheckout

So we won't generate a new patron per checkout

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 13 Owen Leonard 2025-07-17 16:44:38 UTC
Created attachment 184231 [details] [review]
Bug 40345: Add insertSamplePatron

So it's easier to build and insert a new patron

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 14 Owen Leonard 2025-07-17 16:44:41 UTC
Created attachment 184232 [details] [review]
Bug 40345: Force checkout

Pass the confirmation token to force the checkout

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 15 Owen Leonard 2025-07-17 16:44:43 UTC
Created attachment 184233 [details] [review]
Bug 40345: Add tests for bug 38102

Test plan:
  yarn cypress run --spec t/cypress/integration/KohaTable/OPACCirculationHistory_spec.ts
must return green

Revert commits from bug 38102
Run again the Cypress tests
=> They fail

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 16 Owen Leonard 2025-07-17 16:44:46 UTC
Created attachment 184234 [details] [review]
Bug 40345: Properly cleanup old checkouts

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 17 Owen Leonard 2025-07-17 16:44:49 UTC
Created attachment 184235 [details] [review]
Bug 40345: Use then to prevent async issues

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 18 Martin Renvoize (ashimema) 2025-07-18 11:27:55 UTC
Created attachment 184343 [details] [review]
Bug 40345: Pass a patron to insertSampleCheckout

So we won't generate a new patron per checkout

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Comment 19 Martin Renvoize (ashimema) 2025-07-18 11:27:57 UTC
Created attachment 184344 [details] [review]
Bug 40345: Add insertSamplePatron

So it's easier to build and insert a new patron

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Comment 20 Martin Renvoize (ashimema) 2025-07-18 11:27:59 UTC
Created attachment 184345 [details] [review]
Bug 40345: Force checkout

Pass the confirmation token to force the checkout

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Comment 21 Martin Renvoize (ashimema) 2025-07-18 11:28:01 UTC
Created attachment 184346 [details] [review]
Bug 40345: Add tests for bug 38102

Test plan:
  yarn cypress run --spec t/cypress/integration/KohaTable/OPACCirculationHistory_spec.ts
must return green

Revert commits from bug 38102
Run again the Cypress tests
=> They fail

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Comment 22 Martin Renvoize (ashimema) 2025-07-18 11:28:03 UTC
Created attachment 184347 [details] [review]
Bug 40345: Properly cleanup old checkouts

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Comment 23 Martin Renvoize (ashimema) 2025-07-18 11:28:05 UTC
Created attachment 184348 [details] [review]
Bug 40345: Use then to prevent async issues

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Comment 24 Lucas Gass (lukeg) 2025-07-21 20:03:39 UTC
Nice work everyone!

Pushed to main for 25.11
Comment 25 Paul Derscheid 2025-08-22 08:29:26 UTC
Nice work everyone!

Pushed to 25.05.x