In the Checkout history tab of the OPAC, the 'Showing last 50 items/how all items' feature isn't working properly in 24.05. If I have a patron with over 50 items, all items are displaying on that tab when 'Showing last 50 items' should be active by default. If I click 'Show all items' to reload the page (which shows, as expected, all items), but then click 'Show last 50 items', I still see all items, not just the first 50.
Still present in 24.11. I have a patron with a rather large checkout history (3,000+ rows) and this bug seems to be preventing the page from loading for them at all.
The limit number is being passed correctly, but it doesn't seem to be doing anything: my $checkouts = [ $patron->checkouts( {}, { order_by => $order, prefetch => { item => { biblio => 'biblioitems' } }, ( $limit ? ( limit => $limit ) : () ), } )->as_list ];
Created attachment 183921 [details] [review] Bug 38102: Fix limit to 50 items in the checkout history - OPAC Checkout history does not limit to 50 items, it's a regression from bug 33949. To limit to 50 items we need to use "rows", not "limit". Test plan: Have more than 50 checkouts and confirm that by default the table only displays 50 entries.
Created attachment 183922 [details] [review] Bug 38102: Fix default sort order DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Unknown column 'date_due desc' in 'order clause' at /kohadevbox/koha/Koha/Objects.pm line 401
Created attachment 184206 [details] [review] Bug 38102: Fix limit to 50 items in the checkout history - OPAC Checkout history does not limit to 50 items, it's a regression from bug 33949. To limit to 50 items we need to use "rows", not "limit". Test plan: Have more than 50 checkouts and confirm that by default the table only displays 50 entries. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 184207 [details] [review] Bug 38102: Fix default sort order DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Unknown column 'date_due desc' in 'order clause' at /kohadevbox/koha/Koha/Objects.pm line 401 Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 184321 [details] [review] Bug 38102: Fix limit to 50 items in the checkout history - OPAC Checkout history does not limit to 50 items, it's a regression from bug 33949. To limit to 50 items we need to use "rows", not "limit". Test plan: Have more than 50 checkouts and confirm that by default the table only displays 50 entries. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Created attachment 184322 [details] [review] Bug 38102: Fix default sort order DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Unknown column 'date_due desc' in 'order clause' at /kohadevbox/koha/Koha/Objects.pm line 401 Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Nice work everyone! Pushed to main for 25.11
Nice work everyone! Pushed to 25.05.x
Pushed to 24.11.x for 24.11.08