Summary: | Make overdue_notices.pl quiet if there are no libraries with active overdue rules | ||
---|---|---|---|
Product: | Koha | Reporter: | Aleisha Amohia <aleisha> |
Component: | Command-line Utilities | Assignee: | Aleisha Amohia <aleisha> |
Status: | Pushed to main --- | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | anke.bruns, dcook, lisette, m.de.rooy, robin |
Version: | Main | Keywords: | no-sandbox |
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25635 | ||
GIT URL: | Change sponsored?: | Sponsored | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
25.05.00
|
Circulation function: | |
Attachments: |
Bug 38307: Make overdue_notices.pl die quietly if no branches have overdue rules
Bug 38307: Make overdue_notices.pl die quietly if no branches have overdue rules Bug 38307: Make overdue_notices.pl die quietly if no branches have overdue rules |
Description
Aleisha Amohia
2024-10-31 03:16:51 UTC
Created attachment 173742 [details] [review] Bug 38307: Make overdue_notices.pl die quietly if no branches have overdue rules If no patron categories require overdue notices, then there will be no overdue rules/status triggers. This isn't necessarily a bad thing and shouldn't be noisy. To test: 1. Go to Administration -> Patron categories 2. Set all your category types to have overdue notice required: No 3. Go to Tools -> Overdue notices/status triggers 4. Notice you're unable to set any overdue rules 5. Run the cronjob misc/cronjobs/overdue_notices.pl and notice the error about no overdue rules is printed 6. Apply the patch and restart services 7. Run the cronjob misc/cronjobs/overdue_notices.pl and notice the error is not printed 8. Run the cronjob misc/cronjobs/overdue_notices.pl --verbose and notice the error is printed Sponsored-by: Catalyst IT *** Bug 25635 has been marked as a duplicate of this bug. *** Not testable in a sandbox. Created attachment 176383 [details] [review] Bug 38307: Make overdue_notices.pl die quietly if no branches have overdue rules If no patron categories require overdue notices, then there will be no overdue rules/status triggers. This isn't necessarily a bad thing and shouldn't be noisy. To test: 1. Go to Administration -> Patron categories 2. Set all your category types to have overdue notice required: No 3. Go to Tools -> Overdue notices/status triggers 4. Notice you're unable to set any overdue rules 5. Run the cronjob misc/cronjobs/overdue_notices.pl and notice the error about no overdue rules is printed 6. Apply the patch and restart services 7. Run the cronjob misc/cronjobs/overdue_notices.pl and notice the error is not printed 8. Run the cronjob misc/cronjobs/overdue_notices.pl --verbose and notice the error is printed Sponsored-by: Catalyst IT Signed-off-by: Imani Thomas <imani.thomas@bywatersolutions.com> Created attachment 178476 [details] [review] Bug 38307: Make overdue_notices.pl die quietly if no branches have overdue rules If no patron categories require overdue notices, then there will be no overdue rules/status triggers. This isn't necessarily a bad thing and shouldn't be noisy. To test: 1. Go to Administration -> Patron categories 2. Set all your category types to have overdue notice required: No 3. Go to Tools -> Overdue notices/status triggers 4. Notice you're unable to set any overdue rules 5. Run the cronjob misc/cronjobs/overdue_notices.pl and notice the error about no overdue rules is printed 6. Apply the patch and restart services 7. Run the cronjob misc/cronjobs/overdue_notices.pl and notice the error is not printed 8. Run the cronjob misc/cronjobs/overdue_notices.pl --verbose and notice the error is printed Sponsored-by: Catalyst IT Signed-off-by: Imani Thomas <imani.thomas@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed for 25.05! Well done everyone, thank you! |