| Summary: | Serials claims table filters aren't working | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Matt Blenkinsop <matt.blenkinsop> |
| Component: | Serials | Assignee: | Matt Blenkinsop <matt.blenkinsop> |
| Status: | RESOLVED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | baptiste.wojtkowski, david, fridolin.somers, jonathan.druart |
| Version: | Main | Keywords: | regression |
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39814 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37094 |
||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
This restores the table filters for serial claims search results - they are now located at the top of the table, and actually work. This was a regression.
|
Version(s) released in: |
25.05.00,24.11.10
|
| Circulation function: | |||
| Bug Depends on: | 36640 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 39775: Restore filtering to the serials claims table
Bug 39775: Restore filtering to the serials claims table Bug 39775: Remove no-sort def Bug 39775: Restore filtering to the serials claims table Bug 39775: Remove no-sort def Bug 39775: [24.11] Restore filters |
||
|
Description
Matt Blenkinsop
2025-04-29 14:21:15 UTC
Created attachment 181666 [details] [review] Bug 39775: Restore filtering to the serials claims table This patch implements the 'add_filters' argument for kohaTable() to restore filtering to the serials claims table Test plan: 1) Navigate to Serials and then Claims (if prompted to create a notice, please do this) 2) If you have no claims listed, return to the serials page and create a new serial (the details of this aren't too important) 3) Return to the serials claims page, try to use one of the filters at the bottom of the table 4) Nothing will happen and the table won't filter 5) Apply patch 6) Hard refresh the browser 7) The filters will now be at the top of the table and should work Created attachment 181668 [details] [review] Bug 39775: Restore filtering to the serials claims table This patch implements the 'add_filters' argument for kohaTable() to restore filtering to the serials claims table Test plan: 1) Navigate to Serials and then Claims (if prompted to create a notice, please do this) 2) If you have no claims listed, return to the serials page and create a new serial (the details of this aren't too important) 3) Return to the serials claims page, try to use one of the filters at the bottom of the table 4) Nothing will happen and the table won't filter 5) Apply patch 6) Hard refresh the browser 7) The filters will now be at the top of the table and should work Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 181669 [details] [review] Bug 39775: Remove no-sort def Not needed. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 181990 [details] [review] Bug 39775: Restore filtering to the serials claims table This patch implements the 'add_filters' argument for kohaTable() to restore filtering to the serials claims table Test plan: 1) Navigate to Serials and then Claims (if prompted to create a notice, please do this) 2) If you have no claims listed, return to the serials page and create a new serial (the details of this aren't too important) 3) Return to the serials claims page, try to use one of the filters at the bottom of the table 4) Nothing will happen and the table won't filter 5) Apply patch 6) Hard refresh the browser 7) The filters will now be at the top of the table and should work Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: David Nind <david@davidnind.com> Created attachment 181991 [details] [review] Bug 39775: Remove no-sort def Not needed. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: David Nind <david@davidnind.com> Adding my sign off, so that Jonathan's can be counted as QA. Pushed for 25.05! Well done everyone, thank you! Tried to backport 24.11 but there are a lot of changes, does not work. Maybe Bug 37094 has some impact. If anyone can create a dedicated patch for 24.11.x, this is a bad regression How to apply on 24.11.x since it uses dataTable() not kohaTable() ? Created attachment 188089 [details] [review] Bug 39775: [24.11] Restore filters Backported to 24.11 and pushed to stable Bug appeared with 24.11.00, no need to backport Bug fix/regression, no changes to the manual required. |