Bug 37094 - Improve layout of serial claims page
Summary: Improve layout of serial claims page
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Serials (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 16721
  Show dependency treegraph
 
Reported: 2024-06-14 14:59 UTC by Owen Leonard
Modified: 2024-09-05 16:17 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 37094: Improve layout of serial claims page (28.63 KB, patch)
2024-06-14 15:28 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 37094: Improve layout of serial claims page (28.66 KB, patch)
2024-06-24 17:55 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 37094: Improve layout of serial claims page (28.71 KB, patch)
2024-08-06 08:46 UTC, PTFS Europe Sandboxes
Details | Diff | Splinter Review
Bug 37094: Improve layout of serial claims page (26.76 KB, patch)
2024-09-05 16:17 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2024-06-14 14:59:10 UTC
I'd like to make some changes to the layout of the serial claims page, moving filters into the sidebar and adding structure to the "Download" and "Send claim" forms.
Comment 1 Owen Leonard 2024-06-14 15:28:49 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2024-06-24 17:55:48 UTC Comment hidden (obsolete)
Comment 3 Thibault Keromnès 2024-07-17 07:14:20 UTC
I had a few issues with the datepicker:
- a weird behaviour if i first pick a date and then try to edit it with mouse & keyboard (say if i pick 07/16/2024 and then replace the 6 with 7 I end up with 07/17/7724)
- not sure if it's a bug but maybe the results should include both dates used in the filter. For the test I had one issue late for each day between 14 and 16th of july. If i filter from 07/15 to 07/15 I have no result. If I go from 15 to 16 I have only the 16

Also for now if you have no claims notice defined you have an alert but can still use the claims function. With the patch you can't until the defined that SERCLAIM notice.

The rest works great :)
Comment 4 Owen Leonard 2024-07-17 12:23:17 UTC
(In reply to Thibault Keromnès from comment #3)

> I had a few issues with the datepicker

> results should include both dates

I think both these issues existed before the patch

> Also for now if you have no claims notice defined you have an alert but can
> still use the claims function.

This works correctly when I test it. The only difference should be that the "Download selected claims" button isn't enabled until you select one or more issues to claim.
Comment 5 Owen Leonard 2024-07-17 14:10:13 UTC
(In reply to Thibault Keromnès from comment #3)
> I had a few issues with the datepicker:
> - a weird behaviour if i first pick a date and then try to edit it with
> mouse & keyboard (say if i pick 07/16/2024 and then replace the 6 with 7 I
> end up with 07/17/7724)

This is Bug 37371
Comment 6 PTFS Europe Sandboxes 2024-08-06 08:46:26 UTC Comment hidden (obsolete)
Comment 7 Michaela Sieber 2024-08-06 08:47:37 UTC
Just a small note: there should be a reload of the page if a notice was sent or a download of the csv file was made. Otherwise you can not see that the claim date and the claims count was updated.
Comment 8 Katrin Fischer 2024-08-06 09:43:38 UTC
(In reply to Michaela Sieber from comment #7)
> Just a small note: there should be a reload of the page if a notice was sent
> or a download of the csv file was made. Otherwise you can not see that the
> claim date and the claims count was updated.

I agree:
Bug 16808 - Serial claims: claiming via CSV export doesn't reload the page
Comment 9 Owen Leonard 2024-09-05 16:17:09 UTC
Created attachment 171096 [details] [review]
Bug 37094: Improve layout of serial claims page

This patch updates the serial claims interface to hopefully make it more
usable:

- Vendor selection and filter issues forms are in the sidebar
- The "Download selected" and "Send notification" forms are now in their
  own columns at the bottom of the table of issues.
- NEW: The "Download selected" and "Send notification" forms are
  disabled unless one or more issues are selected.

To test you'll need more than one vendor with subscriptions that have
late issues.

- Go to Serials -> Claims.
- You should see a "Choose vendor" form in the main part of the page.
  - Choose a vendor.
  - After selecting a vendor you should see the vendor selection form in
    the sidebar along with a "Filter missing issues" form.
  - Confirm that both forms work correctly.
- In the main body of the page you should see the table of missing
  issues.
  ** Previously this table was sorted by default on the checkbox column.
     Since that doesn't make sense I moved the default sort to the
     "Since" column.
- Below the table of issues should should see the "Download selected"
  form. If you have a claim notice defined, you'll also see a "Send
  notification" form, each in their own column.
  - These forms should initially be disabled.
  - When you check a checkbox or click the "Select all" control at the
    top of the checkbox column the forms should become active.
  - Confirm that both forms work correctly.

Sponsored-by: Athens County Public Libraries
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>