Summary: | "Receive shipments" should not open in a new tab/window | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Acquisitions | Assignee: | Matt Blenkinsop <matt.blenkinsop> |
Status: | Pushed to main --- | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | matt.blenkinsop |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
25.11.00
|
Circulation function: | |
Bug Depends on: | 38010 | ||
Bug Blocks: | 38899 | ||
Attachments: |
Bug 40067: Prevent receive shipments opening in a new tab
Bug 40067: Simplify code Bug 40067: Prevent receive shipments opening in a new tab Bug 40067: Simplify code Bug 40067: Add a cypress test Bug 40067: Add a cypress test Bug 40067: Prevent receive shipments opening in a new tab Bug 40067: Simplify code Bug 40067: Add a cypress test Bug 40067: Improve waits and intercepts |
Description
Jonathan Druart
2025-06-04 07:21:03 UTC
Created attachment 182934 [details] [review] Bug 40067: Prevent receive shipments opening in a new tab Test plan: 1) Navigate to a vendor record 2) Click the Receive shipments button 3) It will open in a new tab 4) Apply patch - yarn js:build 5) Hard refresh the browser 6) Repeat steps 1 - 2 7) The page will open in the same tab Created attachment 182949 [details] [review] Bug 40067: Simplify code Created attachment 182950 [details] [review] Bug 40067: Prevent receive shipments opening in a new tab Test plan: 1) Navigate to a vendor record 2) Click the Receive shipments button 3) It will open in a new tab 4) Apply patch - yarn js:build 5) Hard refresh the browser 6) Repeat steps 1 - 2 7) The page will open in the same tab Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 182951 [details] [review] Bug 40067: Simplify code I think we need a test here. Created attachment 182972 [details] [review] Bug 40067: Add a cypress test (In reply to Matt Blenkinsop from comment #6) > Created attachment 182972 [details] [review] [review] > Bug 40067: Add a cypress test Have a look at bug 40051, we should not use cy.wait(delay). Created attachment 182981 [details] [review] Bug 40067: Add a cypress test Created attachment 183000 [details] [review] Bug 40067: Prevent receive shipments opening in a new tab Test plan: 1) Navigate to a vendor record 2) Click the Receive shipments button 3) It will open in a new tab 4) Apply patch - yarn js:build 5) Hard refresh the browser 6) Repeat steps 1 - 2 7) The page will open in the same tab Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 183001 [details] [review] Bug 40067: Simplify code Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 183002 [details] [review] Bug 40067: Add a cypress test Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 183003 [details] [review] Bug 40067: Improve waits and intercepts Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Nice work everyone! Pushed to main for 25.11 |