On the vendor view: http://localhost:8081/cgi-bin/koha/acquisition/vendors/1 click "Receive shipments" in the toolbar http://localhost:8081//cgi-bin/koha/acqui/parcels.pl?booksellerid=1 is opened in a separate tab/window
Created attachment 182934 [details] [review] Bug 40067: Prevent receive shipments opening in a new tab Test plan: 1) Navigate to a vendor record 2) Click the Receive shipments button 3) It will open in a new tab 4) Apply patch - yarn js:build 5) Hard refresh the browser 6) Repeat steps 1 - 2 7) The page will open in the same tab
Created attachment 182949 [details] [review] Bug 40067: Simplify code
Created attachment 182950 [details] [review] Bug 40067: Prevent receive shipments opening in a new tab Test plan: 1) Navigate to a vendor record 2) Click the Receive shipments button 3) It will open in a new tab 4) Apply patch - yarn js:build 5) Hard refresh the browser 6) Repeat steps 1 - 2 7) The page will open in the same tab Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 182951 [details] [review] Bug 40067: Simplify code
I think we need a test here.
Created attachment 182972 [details] [review] Bug 40067: Add a cypress test
(In reply to Matt Blenkinsop from comment #6) > Created attachment 182972 [details] [review] [review] > Bug 40067: Add a cypress test Have a look at bug 40051, we should not use cy.wait(delay).
Created attachment 182981 [details] [review] Bug 40067: Add a cypress test
Created attachment 183000 [details] [review] Bug 40067: Prevent receive shipments opening in a new tab Test plan: 1) Navigate to a vendor record 2) Click the Receive shipments button 3) It will open in a new tab 4) Apply patch - yarn js:build 5) Hard refresh the browser 6) Repeat steps 1 - 2 7) The page will open in the same tab Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 183001 [details] [review] Bug 40067: Simplify code Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 183002 [details] [review] Bug 40067: Add a cypress test Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 183003 [details] [review] Bug 40067: Improve waits and intercepts Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Nice work everyone! Pushed to main for 25.11
Nice work everyone! Pushed to 25.05.x for 25.05.03
Noticed when writing the release note. It also opens in a new tab/window when you click "Receive shipments" in the actions column from the list of vendors: 1. Acquisitions > Search vendors > Search 2. In the actions column, click "Receive shipments". 3. Note that the receive shipment from vendor [name] page opens in a new tab/window. 4. Repeat step 1 5. In the actions column, click "Edit". 6. Note that the edit action edit vendor page opens in the same tab/window (that is, it doesn't open in a new tab/window like the "Receive shipments" action).
(In reply to David Nind from comment #15) > Noticed when writing the release note. > > It also opens in a new tab/window when you click "Receive shipments" in the > actions column from the list of vendors: > 1. Acquisitions > Search vendors > Search > 2. In the actions column, click "Receive shipments". > 3. Note that the receive shipment from vendor [name] page opens in a new > tab/window. > 4. Repeat step 1 > 5. In the actions column, click "Edit". > 6. Note that the edit action edit vendor page opens in the same tab/window > (that is, it doesn't open in a new tab/window like the "Receive shipments" > action). Opened bug 40318.
Depends on Bug 38010, not backported to 24.11
The new test is failing, opening a new bug report. bug 40430.
Nothing to change in the manual.