It's failing on Jenkins because there is no vendor in the DB. 00:54:30 koha_1 | <failure message="Timed out retrying after 10000ms: Expected to find content: 'Receive shipment from vendor My Vendor' within the element: <h1> but never did." type="AssertionError"><![CDATA[AssertionError: Timed out retrying after 10000ms: Expected to find content: 'Receive shipment from vendor My Vendor' within the element: <h1> but never did.
So, here we are. Jenkins is failing on a Cypress test (Toolbar_spec.ts) because it relies on data that is not in the DB: vendor #1 is injected by misc4dev and is not part of the sample data. Which means the test passes locally but fails on Jenkins. To fix this, I need the work I have been working on for the last weeks. Now it's either we have it and I can fix the tests correctly (creating the vendor in DB), or we drop the test.
Created attachment 184196 [details] [review] Bug 40430: Fix Toolbar_spec.ts See comment 1 on the bug. We are adding the capability to insert vendors and baskets. Test plan: Confirm that yarn cypress run t/cypress/integration/Acquisitions/Vendors_spec.ts pass, even if you do not have any vendors in DB.
Created attachment 184197 [details] [review] Bug 40430: Fix Toolbar_spec.ts See comment 1 on the bug. We are adding the capability to insert vendors and baskets. Test plan: Confirm that yarn cypress run t/cypress/integration/Acquisitions/Vendors_spec.ts pass, even if you do not have any vendors in DB.
Created attachment 184198 [details] [review] Bug 40430: Fix Toolbar_spec.ts See comment 1 on the bug. We are adding the capability to insert vendors and baskets. Test plan: Confirm that yarn cypress run t/cypress/integration/Toolbar_spec.ts pass, even if you do not have any vendors in DB.
Created attachment 184238 [details] [review] Bug 40430: Fix Toolbar_spec.ts See comment 1 on the bug. We are adding the capability to insert vendors and baskets. Test plan: Confirm that yarn cypress run t/cypress/integration/Toolbar_spec.ts pass, even if you do not have any vendors in DB. Signed-off-by: Owen Leonard <oleonard@myacpl.org>