Bug 40318 - "Receive shipments" should not open in a new tab/window - vendor list view
Summary: "Receive shipments" should not open in a new tab/window - vendor list view
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low minor
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 40067
Blocks:
  Show dependency treegraph
 
Reported: 2025-07-07 13:21 UTC by Jonathan Druart
Modified: 2025-07-10 06:52 UTC (History)
2 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes the "Receive shipments" action from the table listing vendors in acquisitions - it now opens the receive shipment form in the same window, instead of opening in a new tab or window.
Version(s) released in:
Circulation function:


Attachments
Bug 40318: Add tests (1.57 KB, patch)
2025-07-07 13:24 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 40318: (bug 40067 follow-up) Prevent receive shipments opening in a new tab - vendor list view (1.34 KB, patch)
2025-07-07 13:24 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 40318: Add tests (1.61 KB, patch)
2025-07-07 18:15 UTC, David Nind
Details | Diff | Splinter Review
Bug 40318: (bug 40067 follow-up) Prevent receive shipments opening in a new tab - vendor list view (1.38 KB, patch)
2025-07-07 18:15 UTC, David Nind
Details | Diff | Splinter Review
Bug 40318: Add tests (1.65 KB, patch)
2025-07-10 06:52 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 40318: (bug 40067 follow-up) Prevent receive shipments opening in a new tab - vendor list view (1.39 KB, patch)
2025-07-10 06:52 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2025-07-07 13:21:06 UTC
Same as bug 40067 but for the vendor list view.
Comment 1 Jonathan Druart 2025-07-07 13:24:48 UTC
Created attachment 183840 [details] [review]
Bug 40318: Add tests
Comment 2 Jonathan Druart 2025-07-07 13:24:50 UTC
Created attachment 183841 [details] [review]
Bug 40318: (bug 40067 follow-up) Prevent receive shipments opening in a new tab - vendor list view

1. Acquisitions > Search vendors > Search
2. In the actions column, click "Receive shipments"
=> Without this patch the receive shipment from vendor [name] page opens in a new tab/window
=> With this patch applied it does not
Comment 3 David Nind 2025-07-07 18:15:06 UTC
Created attachment 183847 [details] [review]
Bug 40318: Add tests

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2025-07-07 18:15:09 UTC
Created attachment 183848 [details] [review]
Bug 40318: (bug 40067 follow-up) Prevent receive shipments opening in a new tab - vendor list view

1. Acquisitions > Search vendors > Search
2. In the actions column, click "Receive shipments"
=> Without this patch the receive shipment from vendor [name] page opens in a new tab/window
=> With this patch applied it does not

Signed-off-by: David Nind <david@davidnind.com>
Comment 5 David Nind 2025-07-07 18:18:55 UTC
Thanks Jonathan for fixing!

Testing notes:
1. After applying the patch, run: yarn build
2. The tests pass: yarn cypress run --spec t/cypress/integration/Acquisitions/Vendors_spec.ts
Comment 6 Marcel de Rooy 2025-07-09 14:27:25 UTC
Seeing
[FAIL] t/cypress/integration/Acquisitions/Vendors_spec.ts
   FAIL   forbidden_patterns
                forbidden pattern: .only detected (line 236)
Comment 7 Jonathan Druart 2025-07-10 06:52:33 UTC
Created attachment 183916 [details] [review]
Bug 40318: Add tests

Signed-off-by: David Nind <david@davidnind.com>

Amended-by: Jonathan Druart
Remove '.only'
Comment 8 Jonathan Druart 2025-07-10 06:52:35 UTC
Created attachment 183917 [details] [review]
Bug 40318: (bug 40067 follow-up) Prevent receive shipments opening in a new tab - vendor list view

1. Acquisitions > Search vendors > Search
2. In the actions column, click "Receive shipments"
=> Without this patch the receive shipment from vendor [name] page opens in a new tab/window
=> With this patch applied it does not

Signed-off-by: David Nind <david@davidnind.com>
Comment 9 Jonathan Druart 2025-07-10 06:52:44 UTC
(In reply to Marcel de Rooy from comment #6)
> Seeing
> [FAIL] t/cypress/integration/Acquisitions/Vendors_spec.ts
>    FAIL   forbidden_patterns
>                 forbidden pattern: .only detected (line 236)

Fixed, sorry about that.