Bug 40318 - "Receive shipments" should not open in a new tab/window - vendor list view
Summary: "Receive shipments" should not open in a new tab/window - vendor list view
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low minor
Assignee: Jonathan Druart
QA Contact: Martin Renvoize (ashimema)
URL:
Keywords:
Depends on: 40430 40067
Blocks: 40447
  Show dependency treegraph
 
Reported: 2025-07-07 13:21 UTC by Jonathan Druart
Modified: 2025-08-22 08:29 UTC (History)
3 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes the "Receive shipments" action from the table listing vendors in acquisitions - it now opens the receive shipment form in the same window, instead of opening in a new tab or window.
Version(s) released in:
25.11.00,25.05.03
Circulation function:


Attachments
Bug 40318: Add tests (1.57 KB, patch)
2025-07-07 13:24 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 40318: (bug 40067 follow-up) Prevent receive shipments opening in a new tab - vendor list view (1.34 KB, patch)
2025-07-07 13:24 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 40318: Add tests (1.61 KB, patch)
2025-07-07 18:15 UTC, David Nind
Details | Diff | Splinter Review
Bug 40318: (bug 40067 follow-up) Prevent receive shipments opening in a new tab - vendor list view (1.38 KB, patch)
2025-07-07 18:15 UTC, David Nind
Details | Diff | Splinter Review
Bug 40318: Add tests (1.65 KB, patch)
2025-07-10 06:52 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 40318: (bug 40067 follow-up) Prevent receive shipments opening in a new tab - vendor list view (1.39 KB, patch)
2025-07-10 06:52 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 40318: Add tests (2.92 KB, patch)
2025-07-17 13:22 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 40318: (bug 40067 follow-up) Prevent receive shipments opening in a new tab - vendor list view (1.39 KB, patch)
2025-07-18 09:08 UTC, David Nind
Details | Diff | Splinter Review
Bug 40318: Add tests (2.96 KB, patch)
2025-07-18 09:08 UTC, David Nind
Details | Diff | Splinter Review
Bug 40318: (bug 40067 follow-up) Prevent receive shipments opening in a new tab - vendor list view (1.45 KB, patch)
2025-07-18 11:31 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 40318: Add tests (3.03 KB, patch)
2025-07-18 11:31 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2025-07-07 13:21:06 UTC
Same as bug 40067 but for the vendor list view.
Comment 1 Jonathan Druart 2025-07-07 13:24:48 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2025-07-07 13:24:50 UTC Comment hidden (obsolete)
Comment 3 David Nind 2025-07-07 18:15:06 UTC Comment hidden (obsolete)
Comment 4 David Nind 2025-07-07 18:15:09 UTC Comment hidden (obsolete)
Comment 5 David Nind 2025-07-07 18:18:55 UTC
Thanks Jonathan for fixing!

Testing notes:
1. After applying the patch, run: yarn build
2. The tests pass: yarn cypress run --spec t/cypress/integration/Acquisitions/Vendors_spec.ts
Comment 6 Marcel de Rooy 2025-07-09 14:27:25 UTC
Seeing
[FAIL] t/cypress/integration/Acquisitions/Vendors_spec.ts
   FAIL   forbidden_patterns
                forbidden pattern: .only detected (line 236)
Comment 7 Jonathan Druart 2025-07-10 06:52:33 UTC Comment hidden (obsolete)
Comment 8 Jonathan Druart 2025-07-10 06:52:35 UTC
Created attachment 183917 [details] [review]
Bug 40318: (bug 40067 follow-up) Prevent receive shipments opening in a new tab - vendor list view

1. Acquisitions > Search vendors > Search
2. In the actions column, click "Receive shipments"
=> Without this patch the receive shipment from vendor [name] page opens in a new tab/window
=> With this patch applied it does not

Signed-off-by: David Nind <david@davidnind.com>
Comment 9 Jonathan Druart 2025-07-10 06:52:44 UTC
(In reply to Marcel de Rooy from comment #6)
> Seeing
> [FAIL] t/cypress/integration/Acquisitions/Vendors_spec.ts
>    FAIL   forbidden_patterns
>                 forbidden pattern: .only detected (line 236)

Fixed, sorry about that.
Comment 10 Jonathan Druart 2025-07-17 09:03:43 UTC
The test is not correct, we don't have the vendor in DB on Jenkins (currently we have Toolbar_spec.ts failing)
Comment 11 Jonathan Druart 2025-07-17 13:22:48 UTC
Created attachment 184199 [details] [review]
Bug 40318: Add tests
Comment 12 Jonathan Druart 2025-07-17 13:23:22 UTC
The tests have been rewritten on top of bug 40430.
Comment 13 David Nind 2025-07-18 09:08:30 UTC
Created attachment 184305 [details] [review]
Bug 40318: (bug 40067 follow-up) Prevent receive shipments opening in a new tab - vendor list view

1. Acquisitions > Search vendors > Search
2. In the actions column, click "Receive shipments"
=> Without this patch the receive shipment from vendor [name] page opens in a new tab/window
=> With this patch applied it does not

Signed-off-by: David Nind <david@davidnind.com>
Comment 14 David Nind 2025-07-18 09:08:34 UTC
Created attachment 184306 [details] [review]
Bug 40318: Add tests

Signed-off-by: David Nind <david@davidnind.com>
Comment 15 David Nind 2025-07-18 09:23:31 UTC
Testing notes (using KTD):
1. Enable the RESTBasicAuth system preference.
2. Apply the patches and dependencies: yes | git bz apply 40318
3. Update the API/JavaScript: yarn build
4. Restart everything: restart_all
5. Run the tests - these should pass: yarn cypress run --spec t/cypress/integration/Acquisitions/Vendors_spec.ts
Comment 16 Martin Renvoize (ashimema) 2025-07-18 11:31:25 UTC
Created attachment 184351 [details] [review]
Bug 40318: (bug 40067 follow-up) Prevent receive shipments opening in a new tab - vendor list view

1. Acquisitions > Search vendors > Search
2. In the actions column, click "Receive shipments"
=> Without this patch the receive shipment from vendor [name] page opens in a new tab/window
=> With this patch applied it does not

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Comment 17 Martin Renvoize (ashimema) 2025-07-18 11:31:27 UTC
Created attachment 184352 [details] [review]
Bug 40318: Add tests

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Comment 18 Lucas Gass (lukeg) 2025-07-21 20:03:36 UTC
Nice work everyone!

Pushed to main for 25.11
Comment 19 Paul Derscheid 2025-08-22 08:29:18 UTC
Nice work everyone!

Pushed to 25.05.x