Bug 40277

Summary: Warn in C4::Koha::GetAuthorisedValues()
Product: Koha Reporter: Fridolin Somers <fridolin.somers>
Component: Architecture, internals, and plumbingAssignee: Fridolin Somers <fridolin.somers>
Status: Needs Signoff --- QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: david
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Trivial patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on:    
Bug Blocks: 25790    
Attachments: Bug 40277: Remove warn in C4::Koha::GetAuthorisedValues()

Description Fridolin Somers 2025-06-30 15:00:39 UTC
When using not logged in OPAC, we see warns :
Use of uninitialized value $branch_limit in concatenation (.) or string

It comes from C4::Koha::GetAuthorisedValues() :
     my $branch_limit = C4::Context->userenv ? C4::Context->userenv->{"branch"} : "";
     my $cache_key    = "AuthorisedValues-$category-$opac-$branch_limit";

C4::Context->userenv->{"branch"} can be undef
Comment 1 Fridolin Somers 2025-06-30 15:18:58 UTC
Created attachment 183644 [details] [review]
Bug 40277: Remove warn in C4::Koha::GetAuthorisedValues()

When using not logged in OPAC, we see warns :
Use of uninitialized value $branch_limit in concatenation (.) or string

It comes from C4::Koha::GetAuthorisedValues() :
     my $branch_limit = C4::Context->userenv ? C4::Context->userenv->{"branch"} : "";
     my $cache_key    = "AuthorisedValues-$category-$opac-$branch_limit";

C4::Context->userenv->{"branch"} can be undef

Patch fixes wy using C4::Context::mybranch()

Test plan:
1.1) Without patch
1.2) Go to OPAC without logging in, open some pages
1.3) Check you have the warning in logs
2.1) Apply patch
2.2) Go to OPAC without logging in, open some pages
2.3) Check you don't have the warning in logs
Comment 2 Fridolin Somers 2025-06-30 15:19:54 UTC
Ah I can get this warn on KTD.
Looks like it is when changing language.
Comment 3 David Nind 2025-06-30 21:26:38 UTC
I couldn't replicate the issue on KTD.