When using not logged in OPAC, we see warns : Use of uninitialized value $branch_limit in concatenation (.) or string It comes from C4::Koha::GetAuthorisedValues() : my $branch_limit = C4::Context->userenv ? C4::Context->userenv->{"branch"} : ""; my $cache_key = "AuthorisedValues-$category-$opac-$branch_limit"; C4::Context->userenv->{"branch"} can be undef
Created attachment 183644 [details] [review] Bug 40277: Remove warn in C4::Koha::GetAuthorisedValues() When using not logged in OPAC, we see warns : Use of uninitialized value $branch_limit in concatenation (.) or string It comes from C4::Koha::GetAuthorisedValues() : my $branch_limit = C4::Context->userenv ? C4::Context->userenv->{"branch"} : ""; my $cache_key = "AuthorisedValues-$category-$opac-$branch_limit"; C4::Context->userenv->{"branch"} can be undef Patch fixes wy using C4::Context::mybranch() Test plan: 1.1) Without patch 1.2) Go to OPAC without logging in, open some pages 1.3) Check you have the warning in logs 2.1) Apply patch 2.2) Go to OPAC without logging in, open some pages 2.3) Check you don't have the warning in logs
Ah I can get this warn on KTD. Looks like it is when changing language.
I couldn't replicate the issue on KTD.
(In reply to David Nind from comment #3) > I couldn't replicate the issue on KTD. Set OpacAdvancedSearchTypes to something else than "itemtypes". eg. "loc", then go to http://localhost:8080/cgi-bin/koha/opac-search.pl
Created attachment 183803 [details] [review] Bug 40277: Remove warn in C4::Koha::GetAuthorisedValues() When using the OPAC and you are not logged in, there are warnings in the logs: [WARN] Use of uninitialized value $branch_limit in concatenation (.) or string It comes from C4::Koha::GetAuthorisedValues() : my $branch_limit = C4::Context->userenv ? C4::Context->userenv->{"branch"} : ""; my $cache_key = "AuthorisedValues-$category-$opac-$branch_limit"; C4::Context->userenv->{"branch"} can be undef The patch fixes using C4::Context::mybranch(). Test plan: 1. Set the OpacAdvancedSearchTypes system preference to something other than "itemtypes", for example "loc". 2. Go to OPAC without logging in, and perform a search. 3. Check the /var/log/koha/kohadev/plack-opac-error.log and note the warnings in the log: [WARN] Use of uninitialized value $branch_limit in concatenation (.) or ... (Alternative, tail the logs: tail -f /var/log/koha/kohadev/*.log 4. Apply the patch. 5. Repeat step 2 and check that there are no longer any warnings. 6. Sign off. Signed-off-by: David Nind <david@davidnind.com>
(In reply to Jonathan Druart from comment #4) > (In reply to David Nind from comment #3) > > I couldn't replicate the issue on KTD. > > Set OpacAdvancedSearchTypes to something else than "itemtypes". eg. "loc", > then go to http://localhost:8080/cgi-bin/koha/opac-search.pl Thanks Jonathan! I've amended the commit message to include this step
Created attachment 183838 [details] [review] Bug 40277: Remove warn in C4::Koha::GetAuthorisedValues() When using the OPAC and you are not logged in, there are warnings in the logs: [WARN] Use of uninitialized value $branch_limit in concatenation (.) or string It comes from C4::Koha::GetAuthorisedValues() : my $branch_limit = C4::Context->userenv ? C4::Context->userenv->{"branch"} : ""; my $cache_key = "AuthorisedValues-$category-$opac-$branch_limit"; C4::Context->userenv->{"branch"} can be undef The patch fixes using C4::Context::mybranch(). Test plan: 1. Set the OpacAdvancedSearchTypes system preference to something other than "itemtypes", for example "loc". 2. Go to OPAC without logging in, and perform a search. 3. Check the /var/log/koha/kohadev/plack-opac-error.log and note the warnings in the log: [WARN] Use of uninitialized value $branch_limit in concatenation (.) or ... (Alternative, tail the logs: tail -f /var/log/koha/kohadev/*.log 4. Apply the patch. 5. Repeat step 2 and check that there are no longer any warnings. 6. Sign off. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 183839 [details] [review] Bug 40277: Add a test Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Thanks a lot for the UT Joubu ;)
Nice work everyone! Pushed to main for 25.11
Nice work everyone! Pushed to 25.05.x
Pushed to 24.11.x for 24.11.08