When using not logged in OPAC, we see warns : Use of uninitialized value $branch_limit in concatenation (.) or string It comes from C4::Koha::GetAuthorisedValues() : my $branch_limit = C4::Context->userenv ? C4::Context->userenv->{"branch"} : ""; my $cache_key = "AuthorisedValues-$category-$opac-$branch_limit"; C4::Context->userenv->{"branch"} can be undef
Created attachment 183644 [details] [review] Bug 40277: Remove warn in C4::Koha::GetAuthorisedValues() When using not logged in OPAC, we see warns : Use of uninitialized value $branch_limit in concatenation (.) or string It comes from C4::Koha::GetAuthorisedValues() : my $branch_limit = C4::Context->userenv ? C4::Context->userenv->{"branch"} : ""; my $cache_key = "AuthorisedValues-$category-$opac-$branch_limit"; C4::Context->userenv->{"branch"} can be undef Patch fixes wy using C4::Context::mybranch() Test plan: 1.1) Without patch 1.2) Go to OPAC without logging in, open some pages 1.3) Check you have the warning in logs 2.1) Apply patch 2.2) Go to OPAC without logging in, open some pages 2.3) Check you don't have the warning in logs
Ah I can get this warn on KTD. Looks like it is when changing language.