Summary: | "Receive shipments" should not open in a new tab/window - vendor list view | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Acquisitions | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | Signed Off --- | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | david, m.de.rooy |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: |
This fixes the "Receive shipments" action from the table listing vendors in acquisitions - it now opens the receive shipment form in the same window, instead of opening in a new tab or window.
|
|
Version(s) released in: | Circulation function: | ||
Bug Depends on: | 40067 | ||
Bug Blocks: | |||
Attachments: |
Bug 40318: Add tests
Bug 40318: (bug 40067 follow-up) Prevent receive shipments opening in a new tab - vendor list view Bug 40318: Add tests Bug 40318: (bug 40067 follow-up) Prevent receive shipments opening in a new tab - vendor list view Bug 40318: Add tests Bug 40318: (bug 40067 follow-up) Prevent receive shipments opening in a new tab - vendor list view |
Description
Jonathan Druart
2025-07-07 13:21:06 UTC
Created attachment 183840 [details] [review] Bug 40318: Add tests Created attachment 183841 [details] [review] Bug 40318: (bug 40067 follow-up) Prevent receive shipments opening in a new tab - vendor list view 1. Acquisitions > Search vendors > Search 2. In the actions column, click "Receive shipments" => Without this patch the receive shipment from vendor [name] page opens in a new tab/window => With this patch applied it does not Created attachment 183847 [details] [review] Bug 40318: Add tests Signed-off-by: David Nind <david@davidnind.com> Created attachment 183848 [details] [review] Bug 40318: (bug 40067 follow-up) Prevent receive shipments opening in a new tab - vendor list view 1. Acquisitions > Search vendors > Search 2. In the actions column, click "Receive shipments" => Without this patch the receive shipment from vendor [name] page opens in a new tab/window => With this patch applied it does not Signed-off-by: David Nind <david@davidnind.com> Thanks Jonathan for fixing! Testing notes: 1. After applying the patch, run: yarn build 2. The tests pass: yarn cypress run --spec t/cypress/integration/Acquisitions/Vendors_spec.ts Seeing [FAIL] t/cypress/integration/Acquisitions/Vendors_spec.ts FAIL forbidden_patterns forbidden pattern: .only detected (line 236) Created attachment 183916 [details] [review] Bug 40318: Add tests Signed-off-by: David Nind <david@davidnind.com> Amended-by: Jonathan Druart Remove '.only' Created attachment 183917 [details] [review] Bug 40318: (bug 40067 follow-up) Prevent receive shipments opening in a new tab - vendor list view 1. Acquisitions > Search vendors > Search 2. In the actions column, click "Receive shipments" => Without this patch the receive shipment from vendor [name] page opens in a new tab/window => With this patch applied it does not Signed-off-by: David Nind <david@davidnind.com> (In reply to Marcel de Rooy from comment #6) > Seeing > [FAIL] t/cypress/integration/Acquisitions/Vendors_spec.ts > FAIL forbidden_patterns > forbidden pattern: .only detected (line 236) Fixed, sorry about that. |