Description
Jonathan Druart
2025-07-07 13:21:06 UTC
Created attachment 183840 [details] [review] Bug 40318: Add tests Created attachment 183841 [details] [review] Bug 40318: (bug 40067 follow-up) Prevent receive shipments opening in a new tab - vendor list view 1. Acquisitions > Search vendors > Search 2. In the actions column, click "Receive shipments" => Without this patch the receive shipment from vendor [name] page opens in a new tab/window => With this patch applied it does not Created attachment 183847 [details] [review] Bug 40318: Add tests Signed-off-by: David Nind <david@davidnind.com> Created attachment 183848 [details] [review] Bug 40318: (bug 40067 follow-up) Prevent receive shipments opening in a new tab - vendor list view 1. Acquisitions > Search vendors > Search 2. In the actions column, click "Receive shipments" => Without this patch the receive shipment from vendor [name] page opens in a new tab/window => With this patch applied it does not Signed-off-by: David Nind <david@davidnind.com> Thanks Jonathan for fixing! Testing notes: 1. After applying the patch, run: yarn build 2. The tests pass: yarn cypress run --spec t/cypress/integration/Acquisitions/Vendors_spec.ts Seeing [FAIL] t/cypress/integration/Acquisitions/Vendors_spec.ts FAIL forbidden_patterns forbidden pattern: .only detected (line 236) Created attachment 183916 [details] [review] Bug 40318: Add tests Signed-off-by: David Nind <david@davidnind.com> Amended-by: Jonathan Druart Remove '.only' Created attachment 183917 [details] [review] Bug 40318: (bug 40067 follow-up) Prevent receive shipments opening in a new tab - vendor list view 1. Acquisitions > Search vendors > Search 2. In the actions column, click "Receive shipments" => Without this patch the receive shipment from vendor [name] page opens in a new tab/window => With this patch applied it does not Signed-off-by: David Nind <david@davidnind.com> (In reply to Marcel de Rooy from comment #6) > Seeing > [FAIL] t/cypress/integration/Acquisitions/Vendors_spec.ts > FAIL forbidden_patterns > forbidden pattern: .only detected (line 236) Fixed, sorry about that. The test is not correct, we don't have the vendor in DB on Jenkins (currently we have Toolbar_spec.ts failing) Created attachment 184199 [details] [review] Bug 40318: Add tests The tests have been rewritten on top of bug 40430. Created attachment 184305 [details] [review] Bug 40318: (bug 40067 follow-up) Prevent receive shipments opening in a new tab - vendor list view 1. Acquisitions > Search vendors > Search 2. In the actions column, click "Receive shipments" => Without this patch the receive shipment from vendor [name] page opens in a new tab/window => With this patch applied it does not Signed-off-by: David Nind <david@davidnind.com> Created attachment 184306 [details] [review] Bug 40318: Add tests Signed-off-by: David Nind <david@davidnind.com> Testing notes (using KTD): 1. Enable the RESTBasicAuth system preference. 2. Apply the patches and dependencies: yes | git bz apply 40318 3. Update the API/JavaScript: yarn build 4. Restart everything: restart_all 5. Run the tests - these should pass: yarn cypress run --spec t/cypress/integration/Acquisitions/Vendors_spec.ts Created attachment 184351 [details] [review] Bug 40318: (bug 40067 follow-up) Prevent receive shipments opening in a new tab - vendor list view 1. Acquisitions > Search vendors > Search 2. In the actions column, click "Receive shipments" => Without this patch the receive shipment from vendor [name] page opens in a new tab/window => With this patch applied it does not Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> Created attachment 184352 [details] [review] Bug 40318: Add tests Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> Nice work everyone! Pushed to main for 25.11 Nice work everyone! Pushed to 25.05.x |