Created attachment 184142 [details] [review] Bug 40409: Make Overdues.t fail The test is wrong, the item is not correctly checked in, it should fail. Created attachment 184143 [details] [review] Bug 40409: Remove warnings from t/db_dependent/Overdues.t The tests was wrong, we should make sure the item has been checked in. We were missing the mock userenv: Can't use an undefined value as a HASH reference at /kohadevbox/koha/C4/Circulation.pm line 2744. at /kohadevbox/koha/C4/Circulation.pm line 2787 Created attachment 184300 [details] [review] Bug 40409: Make Overdues.t fail The test is wrong, the item is not correctly checked in, it should fail. Signed-off-by: David Nind <david@davidnind.com> Created attachment 184301 [details] [review] Bug 40409: Remove warnings from t/db_dependent/Overdues.t The tests was wrong, we should make sure the item has been checked in. We were missing the mock userenv: Can't use an undefined value as a HASH reference at /kohadevbox/koha/C4/Circulation.pm line 2744. at /kohadevbox/koha/C4/Circulation.pm line 2787 Signed-off-by: David Nind <david@davidnind.com> Created attachment 184366 [details] [review] Bug 40409: Make Overdues.t fail The test is wrong, the item is not correctly checked in, it should fail. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> Created attachment 184367 [details] [review] Bug 40409: Remove warnings from t/db_dependent/Overdues.t The tests was wrong, we should make sure the item has been checked in. We were missing the mock userenv: Can't use an undefined value as a HASH reference at /kohadevbox/koha/C4/Circulation.pm line 2744. at /kohadevbox/koha/C4/Circulation.pm line 2787 Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> Nice work everyone! Pushed to main for 25.11 Nice work everyone! Pushed to 25.05.x Pushed to 24.11.x for 24.11.08 Not backporting to 22.11.x as it wasn't backported to 24.05.x Test suite related, no changes to the manual required. |
t/db_dependent/Overdues.t .. 1/18 The checkin for the following issue failed, Please go to the about page and check all messages on the 'System information' to see if there are configuration / data issues ({UNKNOW N}: Can't use an undefined value as a HASH reference at /kohadevbox/koha/C4/Circulation.pm line 2744. at /kohadevbox/koha/C4/Circulation.pm line 2787 )$VAR1 = { 'borrowernumber' => 1669, 'auto_renew' => 0, 'returndate' => '2025-07-16 10:22:21', 'unseen_renewals' => 1, 'timestamp' => '2025-07-16 10:22:21', 'note' => 'dgdIcu', 'auto_renew_error' => 'NOnHFifbC42AwnAJ4V', 'lastreneweddate' => '2025-07-16 10:22:21', 'checkin_library' => 'IDWOMcg', 'onsite_checkout' => 0, 'renewals_count' => 0, 'itemnumber' => 1497, 'issuer_id' => 1670, 'branchcode' => 'JbmnNE', 'notedate' => '2025-07-16 10:22:21', 'issue_id' => 153, 'date_due' => '2025-07-16 10:22:21', 'noteseen' => 1, 'issuedate' => '2025-07-16 10:22:21' }; at t/db_dependent/Overdues.t line 552.