Bug 40606

Summary: Remove italics from shelving location in the staff interface
Product: Koha Reporter: Caroline Cyr La Rose <caroline.cyr-la-rose>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: Pushed to stable --- QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: david
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Trivial patch Documentation contact:
Documentation submission: Text to go in the release notes:
This enhancement removes the italics formatting from the shelving location in a record's holdings table, now that it is in its own column. (The formatting was there to differentiate the shelving location from the library name when they were in the same column. This is not necessary anymore.) (This is a follow-up to Bug 15461 - Add shelving location to holdings table as a separate column, added in Koha 25.04.)
Version(s) released in:
25.11.00,25.05.04
Circulation function:
Bug Depends on: 15461    
Bug Blocks:    
Attachments: Bug 40606: Remove italics from shelving location in the staff interface
Bug 40606: Remove italics from shelving location in the staff interface
Bug 40606: Remove italics from shelving location in the staff interface

Description Caroline Cyr La Rose 2025-08-06 14:39:47 UTC
Now that bug 15461 is in Koha, I noticed that even though the shelving location was moved to its own column, the formatting and parentheses were left. That looks weird now that it's in its own colum.

To recreate :
1. Go to a detailed record (make sure it has an item and the item has a shelving location, I used http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=161
--> Note that the shelving location is in parentheses and in italics 

I noticed that some records show the location without the parentheses already, I'm not sure why some have parentheses and some don't.
Comment 1 Caroline Cyr La Rose 2025-08-06 14:47:10 UTC
OK I think it's the permanent location that makes it have parentheses. 
I still think the location should not be in italics when it's in its own column. The italics was there to differentiate it from the branch name.
Comment 2 Caroline Cyr La Rose 2025-08-06 15:01:28 UTC
Created attachment 185158 [details] [review]
Bug 40606: Remove italics from shelving location in the staff interface

This patch removes the italics formatting from the shelving location
now that it is in its own column. The formatting was there to
differentiate the shelving location from the branch name when they were
in the same column. This is not necessary anymore.

To test :
1. Go to a record with items which have a shelving location.
   --> The shelving location is in italics
2. Apply patch
3. `yarn build`
4. Refresh the page (Ctrl + F5)
   --> The shelving location is displayed normally
Comment 3 Caroline Cyr La Rose 2025-08-06 15:02:05 UTC
I did a simple change, but I fear it might be too simple...? Nothing in Koha is that easy.
Comment 4 Owen Leonard 2025-08-06 16:54:35 UTC
Created attachment 185164 [details] [review]
Bug 40606: Remove italics from shelving location in the staff interface

This patch removes the italics formatting from the shelving location
now that it is in its own column. The formatting was there to
differentiate the shelving location from the branch name when they were
in the same column. This is not necessary anymore.

To test :
1. Go to a record with items which have a shelving location.
   --> The shelving location is in italics
2. Apply patch
3. `yarn build`
4. Refresh the page (Ctrl + F5)
   --> The shelving location is displayed normally

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 5 David Nind 2025-08-15 03:33:04 UTC
Created attachment 185436 [details] [review]
Bug 40606: Remove italics from shelving location in the staff interface

This patch removes the italics formatting from the shelving location
now that it is in its own column. The formatting was there to
differentiate the shelving location from the branch name when they were
in the same column. This is not necessary anymore.

To test :
1. Go to a record with items which have a shelving location.
   --> The shelving location is in italics
2. Apply patch
3. `yarn build`
4. Refresh the page (Ctrl + F5)
   --> The shelving location is displayed normally

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: David Nind <david@davidnind.com>
Comment 6 David Nind 2025-08-15 03:37:05 UTC
Something I can QA!

QA scripts are happy, works as expected.
Comment 7 Lucas Gass (lukeg) 2025-08-20 19:46:16 UTC
Nice work everyone!

Pushed to main for 25.11
Comment 8 Paul Derscheid 2025-09-20 08:58:55 UTC
Nice work everyone!

Pushed to 25.05.x