It would be nice if there was an equivalent setting to OpacLocationBranchToDisplayShelving for the staff interface to determine where the location information is shown.
Could also be solved with colvis column configuration maybe.
+1
I was just looking for this!
*** Bug 30412 has been marked as a duplicate of this bug. ***
Giving this a bump after confirming I don't have the skills to write it myself. We've got a floating collection and would love to hide Home Library in the intranet, but cannot do so without also hiding the shelving location.
We are also a floating library who chose to hide Home Library, but this was problematic as staff can now not quickly see the Shelving Location. Having the ability to move this display to Current Library instead would be really helpful.
Created attachment 162980 [details] [review] Bug 15461: Add StaffLocationOnDetail system preference
Created attachment 162981 [details] [review] Bug 15461: Implement StaffLocationOnDetail To test; 1. APPLY patch, updatedatabase, restart services 2. Search for the new system preference 'StaffLocationOnDetail' 3. Read the description and make sure it makes sense. Check that the 'Table settings' link works. 4. By default it should be set to 'below the home library'. 5. Check to make sure that is where it displays. 6. Try 'below the holding library' and 'below both home and holding libraries', making sure each works properly. 7. Try 'on a sperate column', in which case you need to make sure that 'holdings_shelvinglocation' is properly checked under Administration > Table settings 8. Play with other Table settings to make sure they all work as they should.
Created attachment 162982 [details] [review] Bug 15461: perltidy DB update
Created attachment 162987 [details] [review] Bug 15461: Fix typo in system prefererence description
Created attachment 162990 [details] [review] Bug 15461: Add StaffLocationOnDetail system preference Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Created attachment 162991 [details] [review] Bug 15461: Implement StaffLocationOnDetail To test; 1. APPLY patch, updatedatabase, restart services 2. Search for the new system preference 'StaffLocationOnDetail' 3. Read the description and make sure it makes sense. Check that the 'Table settings' link works. 4. By default it should be set to 'below the home library'. 5. Check to make sure that is where it displays. 6. Try 'below the holding library' and 'below both home and holding libraries', making sure each works properly. 7. Try 'on a sperate column', in which case you need to make sure that 'holdings_shelvinglocation' is properly checked under Administration > Table settings 8. Play with other Table settings to make sure they all work as they should. Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Created attachment 162992 [details] [review] Bug 15461: perltidy DB update Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Created attachment 162993 [details] [review] Bug 15461: Fix typo in system prefererence description Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Sorry guys, this needs a rebase as things have moved around in the templates and includes.
Created attachment 165804 [details] [review] Bug 15461: Add StaffLocationOnDetail
Created attachment 165805 [details] [review] Bug 15461: Add StaffLocationOnDetail system preference To test; 1. APPLY patch, updatedatabase, restart services 2. Search for the new system preference 'StaffLocationOnDetail' 3. Read the description and make sure it makes sense. Check that the 'Table settings' link works. 4. By default it should be set to 'below the home library'. 5. Check to make sure that is where it displays. 6. Try 'below the holding library' and 'below both home and holding libraries', making sure each works properly. 7. Try 'on a sperate column', in which case you need to make sure that 'holdings_shelvinglocation' is properly checked under Administration > Table settings 8. Play with other Table settings to make sure they all work as they should. Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Created attachment 165806 [details] [review] Bug 15461: Perl tidy
rebased for current main, returning status to NQA.
Still applies cleanly, just saying. :p
With the new sorting filters and inability to filter on location by inputting the text of the location, we would really like a way to sort/filter on shelving location in the holdings details. Having a separate column for shelving location seems really helpful here. I am willing to test and sign off as needed.
This breaks column filtering when StaffLocationOnDetail is set to 'on a separate column'.
Oh, this is painful. We can't filter or sort on shelving location at all now. As an academic with many titles in open or closed stacks it hurts.
Created attachment 170238 [details] [review] Bug 15461: (follow-up) Make filtering work right when using seperate column
Back to 'Needs sign-off' here.
Created attachment 170268 [details] [review] Bug 15461: Add StaffLocationOnDetail system preference To test; 1. APPLY patch, updatedatabase, restart services 2. Search for the new system preference 'StaffLocationOnDetail' 3. Read the description and make sure it makes sense. Check that the 'Table settings' link works. 4. By default it should be set to 'below the home library'. 5. Check to make sure that is where it displays. 6. Try 'below the holding library' and 'below both home and holding libraries', making sure each works properly. 7. Try 'on a sperate column', in which case you need to make sure that 'holdings_shelvinglocation' is properly checked under Administration > Table settings 8. Play with other Table settings to make sure they all work as they should. Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Created attachment 170269 [details] [review] Bug 15461: Perl tidy Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Created attachment 170270 [details] [review] Bug 15461: (follow-up) Make filtering work right when using seperate column Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Doesn't apply cleanly anymore.
Created attachment 174011 [details] [review] Bug 15461: Add StaffLocationOnDetail system preference To test; 1. APPLY patch, updatedatabase, restart services 2. Search for the new system preference 'StaffLocationOnDetail' 3. Read the description and make sure it makes sense. Check that the 'Table settings' link works. 4. By default it should be set to 'below the home library'. 5. Check to make sure that is where it displays. 6. Try 'below the holding library' and 'below both home and holding libraries', making sure each works properly. 7. Try 'on a sperate column', in which case you need to make sure that 'holdings_shelvinglocation' is properly checked under Administration > Table settings 8. Play with other Table settings to make sure they all work as they should. Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Created attachment 174012 [details] [review] Bug 15461: Perl tidy Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Created attachment 174013 [details] [review] Bug 15461: (follow-up) Make filtering work right when using seperate column Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Rebased.
Does it work at the OPAC? Last time I checked it was broken.
Re bug 27572 it seems that we want to get rid of the pref.
(In reply to Jonathan Druart from comment #36) > Re bug 27572 it seems that we want to get rid of the pref. Are you saying this can't move forward?
(In reply to Jonathan Druart from comment #36) > Re bug 27572 it seems that we want to get rid of the pref. Maybe we can ditch the system preference all together and just add shelving location as its own column, configued by Table settings?
Hum maybe I am mixing up OpacLocationOnDetail and OpacLocationBranchToDisplay again...
(In reply to Jonathan Druart from comment #39) > Hum maybe I am mixing up OpacLocationOnDetail and > OpacLocationBranchToDisplay again... I will redo this bug without a system preference, it seems unneeded since we can make shelving location its own column. We can also file a Bug to remove OpacLocationOnDetail, in my opinion.
Created attachment 175857 [details] [review] Bug 15461: Add stand alone shevling location column to holdings table To test: 1. APPLY patch and restart_all 2. Go the detail page for some records and see the shelving location column. 3. Make sure the data looks correct 4. Try Table settings to make sure the column can be properly hidden NOTE: You cannot currently search the holdins table for AV descriptions, only the code.
Created attachment 176142 [details] [review] Bug 15461: Add stand alone shelving location column to holdings table To test: 1. APPLY patch and restart_all 2. Go the detail page for some records and see the shelving location column. 3. Make sure the data looks correct 4. Try Table settings to make sure the column can be properly hidden NOTE: You cannot currently search the holdings table for AV descriptions, only the code. Signed-off-by: David Nind <david@davidnind.com>
The text in the shelving location column is still in italics. This made sense when the value was displayed under the home library, but doesn't now with this change. Odd behavour noticed with the holdings table (not related to this bug): - If you click "Show filters", then all the available columns are shown, not just the default columns. - If you click "Hide filters", all of the available columns are still shown, it doesn't go back to just the default columns. I amended the commit message to fix the spelling.
+ <th id="[% tab | html %]_loction" data-colname="location">Shelving location</th> Typo, "loction"
Caroline, Andrew, Katrin, can you confirm you are happy with this solution?
IIRC correctly the discussion about OpacLocationBranchToDisplayShelving the issue was context. If we have shelving location in a separate column it takes up more space and we lose the context: Does it belong to home library or holding library? I am not sure if this would still be an issue for some libraries of if we can always assume that it's part of the home library and if that is clear to the user.
(In reply to Jonathan Druart from comment #45) > Caroline, Andrew, Katrin, can you confirm you are happy with this solution? This works for me!
Created attachment 176669 [details] [review] Bug 15461: Fix typo in items/catalogue_detail.inc
Created attachment 177751 [details] [review] Bug 15461: Add stand alone shelving location column to holdings table To test: 1. APPLY patch and restart_all 2. Go the detail page for some records and see the shelving location column. 3. Make sure the data looks correct 4. Try Table settings to make sure the column can be properly hidden NOTE: You cannot currently search the holdings table for AV descriptions, only the code. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 177752 [details] [review] Bug 15461: Fix typo in items/catalogue_detail.inc
Created attachment 177756 [details] [review] Bug 15461: Fix typo in items/catalogue_detail.inc
Created attachment 177757 [details] [review] Bug 15461: Add stand alone shelving location column to holdings table To test: 1. APPLY patch and restart_all 2. Go the detail page for some records and see the shelving location column. 3. Make sure the data looks correct 4. Try Table settings to make sure the column can be properly hidden NOTE: You cannot currently search the holdings table for AV descriptions, only the code. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 177758 [details] [review] Bug 15461: Fix typo in items/catalogue_detail.inc
Created attachment 179055 [details] [review] Bug 15461: Add stand alone shelving location column to holdings table To test: 1. APPLY patch and restart_all 2. Go the detail page for some records and see the shelving location column. 3. Make sure the data looks correct 4. Try Table settings to make sure the column can be properly hidden NOTE: You cannot currently search the holdings table for AV descriptions, only the code. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 179056 [details] [review] Bug 15461: Fix typo in items/catalogue_detail.inc Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
(In reply to Katrin Fischer from comment #46) > IIRC correctly the discussion about OpacLocationBranchToDisplayShelving the > issue was context. If we have shelving location in a separate column it > takes up more space and we lose the context: Does it belong to home library > or holding library? > > I am not sure if this would still be an issue for some libraries of if we > can always assume that it's part of the home library and if that is clear to > the user. We only had Andrew and me commenting - can we please bring this up again on mailing list or in the libraries channel on Mattermost?
I like Lucas's idea here: Maybe we can ditch the system preference all together and just add shelving location as its own column, configued by Table settings? Knocks out a system preference and allows libraries to show or hide it as they want.
And continues the move toward more customizations being configurable by table settings and user preference.
I agree that a separate column for Shelving Location in the holdings table (perhaps clarifying somehow that this LOC is for the Home Library) sounds like a great idea. And I'm always down for trading a system preference for more control through column configuration settings!
(In reply to hebah from comment #57) > I like Lucas's idea here: Maybe we can ditch the system preference all > together and just add shelving location as its own column, configued by > Table settings? > > Knocks out a system preference and allows libraries to show or hide it as > they want. Just in case of a misunderstanding: there is no system preference for the staff interface currently (only for the OPAC: OpacLocationOnDetail) and with this patch having the location show below homebranch or holdingbranch is no longer an option. It will now only show in a separate column or not at all depending on table configuration and data. @Lucas: can you please state that clearly for release notes?
Pushed for 25.05! Well done everyone, thank you!