Bug 15461 - Add shelving location to holdings table as a separate column
Summary: Add shelving location to holdings table as a separate column
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Lucas Gass (lukeg)
QA Contact: Marcel de Rooy
URL:
Keywords: release-notes-needed
: 30412 (view as bug list)
Depends on: 33568
Blocks:
  Show dependency treegraph
 
Reported: 2016-01-04 14:46 UTC by Katrin Fischer
Modified: 2025-03-17 11:02 UTC (History)
21 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.05.00
Circulation function:


Attachments
Bug 15461: Add StaffLocationOnDetail system preference (2.57 KB, patch)
2024-03-08 21:11 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 15461: Implement StaffLocationOnDetail (8.81 KB, patch)
2024-03-08 21:11 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 15461: perltidy DB update (1.13 KB, patch)
2024-03-08 21:12 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 15461: Fix typo in system prefererence description (1.58 KB, patch)
2024-03-08 21:43 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 15461: Add StaffLocationOnDetail system preference (2.63 KB, patch)
2024-03-08 21:57 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 15461: Implement StaffLocationOnDetail (8.87 KB, patch)
2024-03-08 21:57 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 15461: perltidy DB update (1.18 KB, patch)
2024-03-08 21:57 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 15461: Fix typo in system prefererence description (1.63 KB, patch)
2024-03-08 21:57 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 15461: Add StaffLocationOnDetail (1.13 KB, patch)
2024-04-29 20:17 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 15461: Add StaffLocationOnDetail system preference (10.47 KB, patch)
2024-04-29 20:18 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 15461: Perl tidy (1.12 KB, patch)
2024-04-29 20:18 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 15461: (follow-up) Make filtering work right when using seperate column (1.91 KB, patch)
2024-08-12 19:47 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 15461: Add StaffLocationOnDetail system preference (10.47 KB, patch)
2024-08-13 16:12 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 15461: Perl tidy (1.18 KB, patch)
2024-08-13 16:12 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 15461: (follow-up) Make filtering work right when using seperate column (1.97 KB, patch)
2024-08-13 16:12 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 15461: Add StaffLocationOnDetail system preference (10.79 KB, patch)
2024-11-05 17:07 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 15461: Perl tidy (1.18 KB, patch)
2024-11-05 17:07 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 15461: (follow-up) Make filtering work right when using seperate column (1.97 KB, patch)
2024-11-05 17:07 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 15461: Add stand alone shevling location column to holdings table (3.50 KB, patch)
2024-12-20 21:35 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 15461: Add stand alone shelving location column to holdings table (3.55 KB, patch)
2025-01-03 19:53 UTC, David Nind
Details | Diff | Splinter Review
Bug 15461: Fix typo in items/catalogue_detail.inc (1.50 KB, patch)
2025-01-16 14:55 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 15461: Add stand alone shelving location column to holdings table (3.56 KB, patch)
2025-02-11 18:59 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 15461: Fix typo in items/catalogue_detail.inc (1.50 KB, patch)
2025-02-11 18:59 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 15461: Fix typo in items/catalogue_detail.inc (1.53 KB, patch)
2025-02-11 20:07 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 15461: Add stand alone shelving location column to holdings table (3.87 KB, patch)
2025-02-11 20:07 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 15461: Fix typo in items/catalogue_detail.inc (1.53 KB, patch)
2025-02-11 20:07 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 15461: Add stand alone shelving location column to holdings table (3.96 KB, patch)
2025-03-07 10:32 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 15461: Fix typo in items/catalogue_detail.inc (1.62 KB, patch)
2025-03-07 10:32 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2016-01-04 14:46:10 UTC
It would be nice if there was an equivalent setting to OpacLocationBranchToDisplayShelving for the staff interface to determine where the location information is shown.
Comment 1 Katrin Fischer 2017-12-28 16:29:06 UTC
Could also be solved with colvis column configuration maybe.
Comment 2 Andrew Fuerste-Henry 2020-07-08 21:30:14 UTC
+1
Comment 3 Caroline Cyr La Rose 2021-07-08 15:36:38 UTC
I was just looking for this!
Comment 4 Noémie Labine 2022-04-25 17:19:56 UTC
+1
Comment 5 Katrin Fischer 2023-06-17 20:03:07 UTC
*** Bug 30412 has been marked as a duplicate of this bug. ***
Comment 6 Andrew Fuerste-Henry 2024-01-05 20:57:37 UTC
Giving this a bump after confirming I don't have the skills to write it myself. We've got a floating collection and would love to hide Home Library in the intranet, but cannot do so without also hiding the shelving location.
Comment 7 Keith Dembek 2024-02-28 18:05:47 UTC
We are also a floating library who chose to hide Home Library, but this was problematic as staff can now not quickly see the Shelving Location. Having the ability to move this display to Current Library instead would be really helpful.
Comment 8 Lucas Gass (lukeg) 2024-03-08 21:11:57 UTC
Created attachment 162980 [details] [review]
Bug 15461: Add StaffLocationOnDetail system preference
Comment 9 Lucas Gass (lukeg) 2024-03-08 21:11:59 UTC
Created attachment 162981 [details] [review]
Bug 15461: Implement StaffLocationOnDetail

To test;
1. APPLY patch, updatedatabase, restart services
2. Search for the new system preference 'StaffLocationOnDetail'
3. Read the description and make sure it makes sense. Check that the 'Table settings' link works.
4. By default it should be set to 'below the home library'.
5. Check to make sure that is where it displays.
6. Try 'below the holding library' and 'below both home and holding libraries', making sure each works properly.
7. Try 'on a sperate column', in which case you need to make sure that 'holdings_shelvinglocation' is properly checked under Administration > Table settings
8. Play with other Table settings to make sure they all work as they should.
Comment 10 Lucas Gass (lukeg) 2024-03-08 21:12:02 UTC
Created attachment 162982 [details] [review]
Bug 15461: perltidy DB update
Comment 11 Lucas Gass (lukeg) 2024-03-08 21:43:18 UTC
Created attachment 162987 [details] [review]
Bug 15461: Fix typo in system prefererence description
Comment 12 ByWater Sandboxes 2024-03-08 21:57:40 UTC
Created attachment 162990 [details] [review]
Bug 15461: Add StaffLocationOnDetail system preference

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 13 ByWater Sandboxes 2024-03-08 21:57:43 UTC
Created attachment 162991 [details] [review]
Bug 15461: Implement StaffLocationOnDetail

To test;
1. APPLY patch, updatedatabase, restart services
2. Search for the new system preference 'StaffLocationOnDetail'
3. Read the description and make sure it makes sense. Check that the 'Table settings' link works.
4. By default it should be set to 'below the home library'.
5. Check to make sure that is where it displays.
6. Try 'below the holding library' and 'below both home and holding libraries', making sure each works properly.
7. Try 'on a sperate column', in which case you need to make sure that 'holdings_shelvinglocation' is properly checked under Administration > Table settings
8. Play with other Table settings to make sure they all work as they should.

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 14 ByWater Sandboxes 2024-03-08 21:57:46 UTC
Created attachment 162992 [details] [review]
Bug 15461: perltidy DB update

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 15 ByWater Sandboxes 2024-03-08 21:57:48 UTC
Created attachment 162993 [details] [review]
Bug 15461: Fix typo in system prefererence description

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 16 Martin Renvoize (ashimema) 2024-04-25 11:17:45 UTC
Sorry guys, this needs a rebase as things have moved around in the templates and includes.
Comment 17 Lucas Gass (lukeg) 2024-04-29 20:17:10 UTC
Created attachment 165804 [details] [review]
Bug 15461: Add StaffLocationOnDetail
Comment 18 Lucas Gass (lukeg) 2024-04-29 20:18:42 UTC
Created attachment 165805 [details] [review]
Bug 15461: Add StaffLocationOnDetail system preference

To test;
1. APPLY patch, updatedatabase, restart services
2. Search for the new system preference 'StaffLocationOnDetail'
3. Read the description and make sure it makes sense. Check that the 'Table settings' link works.
4. By default it should be set to 'below the home library'.
5. Check to make sure that is where it displays.
6. Try 'below the holding library' and 'below both home and holding libraries', making sure each works properly.
7. Try 'on a sperate column', in which case you need to make sure that 'holdings_shelvinglocation' is properly checked under Administration > Table settings
8. Play with other Table settings to make sure they all work as they should.

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 19 Lucas Gass (lukeg) 2024-04-29 20:18:45 UTC
Created attachment 165806 [details] [review]
Bug 15461: Perl tidy
Comment 20 Lucas Gass (lukeg) 2024-04-29 20:20:04 UTC
rebased for current main, returning status to NQA.
Comment 21 Lucas Gass (lukeg) 2024-06-17 19:06:52 UTC
Still applies cleanly, just saying. :p
Comment 22 Dani Elder 2024-07-15 19:45:10 UTC
With the new sorting filters and inability to filter on location by inputting the text of the location, we would really like a way to sort/filter on shelving location in the holdings details. Having a separate column for shelving location seems really helpful here. I am willing to test and sign off as needed.
Comment 23 Lucas Gass (lukeg) 2024-07-16 16:32:49 UTC
This breaks column filtering when StaffLocationOnDetail  is set to 'on a separate column'.
Comment 24 Dani Elder 2024-07-23 20:15:48 UTC
Oh, this is painful.  We can't filter or sort on shelving location at all now. As an academic with many titles in open or closed stacks it hurts.
Comment 25 Lucas Gass (lukeg) 2024-08-12 19:47:58 UTC
Created attachment 170238 [details] [review]
Bug 15461: (follow-up) Make filtering work right when using seperate column
Comment 26 Lucas Gass (lukeg) 2024-08-12 19:48:39 UTC
Back to 'Needs sign-off' here.
Comment 27 ByWater Sandboxes 2024-08-13 16:12:30 UTC
Created attachment 170268 [details] [review]
Bug 15461: Add StaffLocationOnDetail system preference

To test;
1. APPLY patch, updatedatabase, restart services
2. Search for the new system preference 'StaffLocationOnDetail'
3. Read the description and make sure it makes sense. Check that the 'Table settings' link works.
4. By default it should be set to 'below the home library'.
5. Check to make sure that is where it displays.
6. Try 'below the holding library' and 'below both home and holding libraries', making sure each works properly.
7. Try 'on a sperate column', in which case you need to make sure that 'holdings_shelvinglocation' is properly checked under Administration > Table settings
8. Play with other Table settings to make sure they all work as they should.

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 28 ByWater Sandboxes 2024-08-13 16:12:33 UTC
Created attachment 170269 [details] [review]
Bug 15461: Perl tidy

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 29 ByWater Sandboxes 2024-08-13 16:12:36 UTC
Created attachment 170270 [details] [review]
Bug 15461: (follow-up) Make filtering work right when using seperate column

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 30 Lucas Gass (lukeg) 2024-11-05 17:03:30 UTC
Doesn't apply cleanly anymore.
Comment 31 Lucas Gass (lukeg) 2024-11-05 17:07:34 UTC
Created attachment 174011 [details] [review]
Bug 15461: Add StaffLocationOnDetail system preference

To test;
1. APPLY patch, updatedatabase, restart services
2. Search for the new system preference 'StaffLocationOnDetail'
3. Read the description and make sure it makes sense. Check that the 'Table settings' link works.
4. By default it should be set to 'below the home library'.
5. Check to make sure that is where it displays.
6. Try 'below the holding library' and 'below both home and holding libraries', making sure each works properly.
7. Try 'on a sperate column', in which case you need to make sure that 'holdings_shelvinglocation' is properly checked under Administration > Table settings
8. Play with other Table settings to make sure they all work as they should.

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 32 Lucas Gass (lukeg) 2024-11-05 17:07:38 UTC
Created attachment 174012 [details] [review]
Bug 15461: Perl tidy

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 33 Lucas Gass (lukeg) 2024-11-05 17:07:41 UTC
Created attachment 174013 [details] [review]
Bug 15461: (follow-up) Make filtering work right when using seperate column

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 34 Lucas Gass (lukeg) 2024-11-05 17:08:39 UTC
Rebased.
Comment 35 Jonathan Druart 2024-12-18 09:36:43 UTC
Does it work at the OPAC? Last time I checked it was broken.
Comment 36 Jonathan Druart 2024-12-18 09:38:04 UTC
Re bug 27572 it seems that we want to get rid of the pref.
Comment 37 Lucas Gass (lukeg) 2024-12-18 15:07:11 UTC
(In reply to Jonathan Druart from comment #36)
> Re bug 27572 it seems that we want to get rid of the pref.

Are you saying this can't move forward?
Comment 38 Lucas Gass (lukeg) 2024-12-18 15:08:08 UTC
(In reply to Jonathan Druart from comment #36)
> Re bug 27572 it seems that we want to get rid of the pref.

Maybe we can ditch the system preference all together and just add shelving location as its own column, configued by Table settings?
Comment 39 Jonathan Druart 2024-12-18 15:47:12 UTC
Hum maybe I am mixing up OpacLocationOnDetail and OpacLocationBranchToDisplay again...
Comment 40 Lucas Gass (lukeg) 2024-12-19 18:49:14 UTC
(In reply to Jonathan Druart from comment #39)
> Hum maybe I am mixing up OpacLocationOnDetail and
> OpacLocationBranchToDisplay again...

I will redo this bug without a system preference, it seems unneeded since we can make shelving location its own column.

We can also file a Bug to remove OpacLocationOnDetail, in my opinion.
Comment 41 Lucas Gass (lukeg) 2024-12-20 21:35:23 UTC
Created attachment 175857 [details] [review]
Bug 15461: Add stand alone shevling location column to holdings table

To test:
1. APPLY patch and restart_all
2. Go the detail page for some records and see the shelving location column.
3. Make sure the data looks correct
4. Try Table settings to make sure the column can be properly hidden

NOTE: You cannot currently search the holdins table for AV descriptions, only the code.
Comment 42 David Nind 2025-01-03 19:53:27 UTC
Created attachment 176142 [details] [review]
Bug 15461: Add stand alone shelving location column to holdings table

To test:
1. APPLY patch and restart_all
2. Go the detail page for some records and see the shelving location column.
3. Make sure the data looks correct
4. Try Table settings to make sure the column can be properly hidden

NOTE: You cannot currently search the holdings table for AV descriptions, only the code.
Signed-off-by: David Nind <david@davidnind.com>
Comment 43 David Nind 2025-01-03 20:05:03 UTC
The text in the shelving location column is still in italics.

This made sense when the value was displayed under the home library, but doesn't now with this change.

Odd behavour noticed with the holdings table (not related to this bug):
- If you click "Show filters", then all the available columns are shown, not just the default columns.
- If you click "Hide filters", all of the available columns are still shown, it doesn't go back to just the default columns.

I amended the commit message to fix the spelling.
Comment 44 Jonathan Druart 2025-01-16 09:24:56 UTC
+            <th id="[% tab | html %]_loction" data-colname="location">Shelving location</th>

Typo, "loction"
Comment 45 Jonathan Druart 2025-01-16 09:25:30 UTC
Caroline, Andrew, Katrin, can you confirm you are happy with this solution?
Comment 46 Katrin Fischer 2025-01-16 13:21:19 UTC
IIRC correctly the discussion about OpacLocationBranchToDisplayShelving the issue was context. If we have shelving location in a separate column it takes up more space and we lose the context: Does it belong to home library or holding library?

I am not sure if this would still be an issue for some libraries of if we can always assume that it's part of the home library and if that is clear to the user.
Comment 47 Andrew Fuerste-Henry 2025-01-16 13:44:36 UTC
(In reply to Jonathan Druart from comment #45)
> Caroline, Andrew, Katrin, can you confirm you are happy with this solution?

This works for me!
Comment 48 Lucas Gass (lukeg) 2025-01-16 14:55:17 UTC
Created attachment 176669 [details] [review]
Bug 15461: Fix typo in items/catalogue_detail.inc
Comment 49 Lucas Gass (lukeg) 2025-02-11 18:59:01 UTC
Created attachment 177751 [details] [review]
Bug 15461: Add stand alone shelving location column to holdings table

To test:
1. APPLY patch and restart_all
2. Go the detail page for some records and see the shelving location column.
3. Make sure the data looks correct
4. Try Table settings to make sure the column can be properly hidden

NOTE: You cannot currently search the holdings table for AV descriptions, only the code.
Signed-off-by: David Nind <david@davidnind.com>
Comment 50 Lucas Gass (lukeg) 2025-02-11 18:59:06 UTC
Created attachment 177752 [details] [review]
Bug 15461: Fix typo in items/catalogue_detail.inc
Comment 51 Lucas Gass (lukeg) 2025-02-11 20:07:25 UTC
Created attachment 177756 [details] [review]
Bug 15461: Fix typo in items/catalogue_detail.inc
Comment 52 Lucas Gass (lukeg) 2025-02-11 20:07:50 UTC
Created attachment 177757 [details] [review]
Bug 15461: Add stand alone shelving location column to holdings table

To test:
1. APPLY patch and restart_all
2. Go the detail page for some records and see the shelving location column.
3. Make sure the data looks correct
4. Try Table settings to make sure the column can be properly hidden

NOTE: You cannot currently search the holdings table for AV descriptions, only the code.
Signed-off-by: David Nind <david@davidnind.com>
Comment 53 Lucas Gass (lukeg) 2025-02-11 20:07:54 UTC
Created attachment 177758 [details] [review]
Bug 15461: Fix typo in items/catalogue_detail.inc
Comment 54 Marcel de Rooy 2025-03-07 10:32:20 UTC
Created attachment 179055 [details] [review]
Bug 15461: Add stand alone shelving location column to holdings table

To test:
1. APPLY patch and restart_all
2. Go the detail page for some records and see the shelving location column.
3. Make sure the data looks correct
4. Try Table settings to make sure the column can be properly hidden

NOTE: You cannot currently search the holdings table for AV descriptions, only the code.
Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 55 Marcel de Rooy 2025-03-07 10:32:24 UTC
Created attachment 179056 [details] [review]
Bug 15461: Fix typo in items/catalogue_detail.inc

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 56 Katrin Fischer 2025-03-07 16:49:58 UTC
(In reply to Katrin Fischer from comment #46)
> IIRC correctly the discussion about OpacLocationBranchToDisplayShelving the
> issue was context. If we have shelving location in a separate column it
> takes up more space and we lose the context: Does it belong to home library
> or holding library?
> 
> I am not sure if this would still be an issue for some libraries of if we
> can always assume that it's part of the home library and if that is clear to
> the user.

We only had Andrew and me commenting - can we please bring this up again on mailing list or in the libraries channel on Mattermost?
Comment 57 hebah 2025-03-07 20:39:26 UTC
I like Lucas's idea here: Maybe we can ditch the system preference all together and just add shelving location as its own column, configued by Table settings?

Knocks out a system preference and allows libraries to show or hide it as they want.
Comment 58 hebah 2025-03-07 20:40:47 UTC
And continues the move toward more customizations being configurable by table settings and user preference.
Comment 59 Heather Rommens 2025-03-07 20:48:37 UTC
I agree that a separate column for Shelving Location in the holdings table (perhaps clarifying somehow that this LOC is for the Home Library) sounds like a great idea. And I'm always down for trading a system preference for more control through column configuration settings!
Comment 60 Katrin Fischer 2025-03-17 10:46:54 UTC
(In reply to hebah from comment #57)
> I like Lucas's idea here: Maybe we can ditch the system preference all
> together and just add shelving location as its own column, configued by
> Table settings?
> 
> Knocks out a system preference and allows libraries to show or hide it as
> they want.

Just in case of a misunderstanding: there is no system preference for the staff interface currently (only for the OPAC: OpacLocationOnDetail) and with this patch having the location show below homebranch or holdingbranch is no longer an option. It will now only show in a separate column or not at all depending on table configuration and data. 

@Lucas: can you please state that clearly for release notes?
Comment 61 Katrin Fischer 2025-03-17 11:02:47 UTC
Pushed for 25.05!

Well done everyone, thank you!