Bug 40606 - Remove italics from shelving location in the staff interface
Summary: Remove italics from shelving location in the staff interface
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 15461
Blocks:
  Show dependency treegraph
 
Reported: 2025-08-06 14:39 UTC by Caroline Cyr La Rose
Modified: 2025-08-06 16:54 UTC (History)
0 users

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 40606: Remove italics from shelving location in the staff interface (1.29 KB, patch)
2025-08-06 15:01 UTC, Caroline Cyr La Rose
Details | Diff | Splinter Review
Bug 40606: Remove italics from shelving location in the staff interface (1.34 KB, patch)
2025-08-06 16:54 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2025-08-06 14:39:47 UTC
Now that bug 15461 is in Koha, I noticed that even though the shelving location was moved to its own column, the formatting and parentheses were left. That looks weird now that it's in its own colum.

To recreate :
1. Go to a detailed record (make sure it has an item and the item has a shelving location, I used http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=161
--> Note that the shelving location is in parentheses and in italics 

I noticed that some records show the location without the parentheses already, I'm not sure why some have parentheses and some don't.
Comment 1 Caroline Cyr La Rose 2025-08-06 14:47:10 UTC
OK I think it's the permanent location that makes it have parentheses. 
I still think the location should not be in italics when it's in its own column. The italics was there to differentiate it from the branch name.
Comment 2 Caroline Cyr La Rose 2025-08-06 15:01:28 UTC
Created attachment 185158 [details] [review]
Bug 40606: Remove italics from shelving location in the staff interface

This patch removes the italics formatting from the shelving location
now that it is in its own column. The formatting was there to
differentiate the shelving location from the branch name when they were
in the same column. This is not necessary anymore.

To test :
1. Go to a record with items which have a shelving location.
   --> The shelving location is in italics
2. Apply patch
3. `yarn build`
4. Refresh the page (Ctrl + F5)
   --> The shelving location is displayed normally
Comment 3 Caroline Cyr La Rose 2025-08-06 15:02:05 UTC
I did a simple change, but I fear it might be too simple...? Nothing in Koha is that easy.
Comment 4 Owen Leonard 2025-08-06 16:54:35 UTC
Created attachment 185164 [details] [review]
Bug 40606: Remove italics from shelving location in the staff interface

This patch removes the italics formatting from the shelving location
now that it is in its own column. The formatting was there to
differentiate the shelving location from the branch name when they were
in the same column. This is not necessary anymore.

To test :
1. Go to a record with items which have a shelving location.
   --> The shelving location is in italics
2. Apply patch
3. `yarn build`
4. Refresh the page (Ctrl + F5)
   --> The shelving location is displayed normally

Signed-off-by: Owen Leonard <oleonard@myacpl.org>