| Summary: | Incorrect show_priority condition in opac-detail | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | OPAC | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | Needs documenting --- | QA Contact: | Nick Clemens (kidclamp) <nick> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | fridolin.somers, lucas, nick |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
25.11.00,25.05.05
|
|
| Circulation function: | |||
| Bug Depends on: | 39276, 39452 | ||
| Bug Blocks: | 30633 | ||
| Attachments: |
Bug 41010: Adjust show_priority condition in opac-detail
Bug 41010: Adjust show_priority condition in opac-detail |
||
|
Description
Jonathan Druart
2025-10-14 09:43:43 UTC
Created attachment 187855 [details] [review] Bug 41010: Adjust show_priority condition in opac-detail We had [% IF item_level_holds > 0 || show_priority %] [% ELSIF show_priority %] We never reach ELSIF. I am not sure what's the correct fix here. People involved on bug 39276 should help. Bug 39276 clashed with bug 39452. The changes from bug 39452 was totally unrelated to the rest of the patch - [% IF item_level_holds > 0 %] + [% IF item_level_holds > 0 || show_priority %] Lucas and Nick, please clarify. Created attachment 188027 [details] [review] Bug 41010: Adjust show_priority condition in opac-detail We had [% IF item_level_holds > 0 || show_priority %] [% ELSIF show_priority %] We never reach ELSIF. I am not sure what's the correct fix here. People involved on bug 39276 should help. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> (In reply to Jonathan Druart from comment #2) > Bug 39276 clashed with bug 39452. > > The changes from bug 39452 was totally unrelated to the rest of the patch > > - [% IF item_level_holds > 0 %] > + [% IF item_level_holds > 0 || show_priority %] > > Lucas and Nick, please clarify. If I had to guess, I was writing 39452 - then tried to help with 39276, and accidentally included an unrelated line. Nice work everyone! Pushed to main for 25.11 Nice work everyone! Pushed to 25.05.x |