Bug 41010

Summary: Incorrect show_priority condition in opac-detail
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: OPACAssignee: Jonathan Druart <jonathan.druart>
Status: Needs documenting --- QA Contact: Nick Clemens (kidclamp) <nick>
Severity: normal    
Priority: P5 - low CC: fridolin.somers, lucas, nick
Version: unspecified   
Hardware: All   
OS: All   
GIT URL: Initiative type: ---
Sponsorship status: --- Comma delimited list of Sponsors:
Crowdfunding goal: 0 Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.11.00,25.05.05
Circulation function:
Bug Depends on: 39276, 39452    
Bug Blocks: 30633    
Attachments: Bug 41010: Adjust show_priority condition in opac-detail
Bug 41010: Adjust show_priority condition in opac-detail

Description Jonathan Druart 2025-10-14 09:43:43 UTC
From bug 39276 comment 12

I don't understand this patch.

Here is the diff:
+                    [% ELSIF show_priority %]
+                        <td class="holds_priority">[% priority | html %] </td>
                     [% END %]

Here is the context:
                    [% IF item_level_holds > 0 || show_priority %]
                        <td class="holds_count">
                            [% IF holds_count.defined %][% ITEM_RESULT.holds_count | html %][% END %]
                            [% IF ITEM_RESULT.priority %]
                                [% IF holds_count.defined %]
                                    <span>(priority [% ITEM_RESULT.priority | html %])</span>
                                [% ELSE %]
                                    <span>[% ITEM_RESULT.priority | html %]</span>
                                [% END %]
                            [% END %]
                        </td>
                    [% ELSIF show_priority %]
                        <td class="holds_priority">[% priority | html %] </td>
                    [% END %]

we never reach the ELSIF, we have || show_priority in the first condition.
Comment 1 Jonathan Druart 2025-10-14 09:50:01 UTC
Created attachment 187855 [details] [review]
Bug 41010: Adjust show_priority condition in opac-detail

We had
[% IF item_level_holds > 0 || show_priority %]
[% ELSIF show_priority %]

We never reach ELSIF.

I am not sure what's the correct fix here. People involved on bug 39276
should help.
Comment 2 Jonathan Druart 2025-10-14 10:07:51 UTC
Bug 39276 clashed with bug 39452.

The changes from bug 39452 was totally unrelated to the rest of the patch

-                    [% IF item_level_holds > 0 %]
+                    [% IF item_level_holds > 0 || show_priority %]

Lucas and Nick, please clarify.
Comment 3 Nick Clemens (kidclamp) 2025-10-16 18:35:58 UTC
Created attachment 188027 [details] [review]
Bug 41010: Adjust show_priority condition in opac-detail

We had
[% IF item_level_holds > 0 || show_priority %]
[% ELSIF show_priority %]

We never reach ELSIF.

I am not sure what's the correct fix here. People involved on bug 39276
should help.

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 4 Nick Clemens (kidclamp) 2025-10-16 18:37:10 UTC
(In reply to Jonathan Druart from comment #2)
> Bug 39276 clashed with bug 39452.
> 
> The changes from bug 39452 was totally unrelated to the rest of the patch
> 
> -                    [% IF item_level_holds > 0 %]
> +                    [% IF item_level_holds > 0 || show_priority %]
> 
> Lucas and Nick, please clarify.

If I had to guess, I was writing 39452 - then tried to help with 39276, and accidentally included an unrelated line.
Comment 5 Lucas Gass (lukeg) 2025-10-20 16:14:49 UTC
Nice work everyone!

Pushed to main for 25.11
Comment 6 Paul Derscheid 2025-10-29 09:10:32 UTC
Nice work everyone!

Pushed to 25.05.x
Comment 7 Fridolin Somers 2025-11-10 15:05:17 UTC
Depends on Bug 39452 not in 24.11.x