Bug 41010

Summary: Incorrect show_priority condition in opac-detail
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: OPACAssignee: Lucas Gass (lukeg) <lucas>
Status: Needs Signoff --- QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low    
Version: unspecified   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 39276, 39452    
Bug Blocks: 30633    
Attachments: Bug 41010: Adjust show_priority condition in opac-detail

Description Jonathan Druart 2025-10-14 09:43:43 UTC
From bug 39276 comment 12

I don't understand this patch.

Here is the diff:
+                    [% ELSIF show_priority %]
+                        <td class="holds_priority">[% priority | html %] </td>
                     [% END %]

Here is the context:
                    [% IF item_level_holds > 0 || show_priority %]
                        <td class="holds_count">
                            [% IF holds_count.defined %][% ITEM_RESULT.holds_count | html %][% END %]
                            [% IF ITEM_RESULT.priority %]
                                [% IF holds_count.defined %]
                                    <span>(priority [% ITEM_RESULT.priority | html %])</span>
                                [% ELSE %]
                                    <span>[% ITEM_RESULT.priority | html %]</span>
                                [% END %]
                            [% END %]
                        </td>
                    [% ELSIF show_priority %]
                        <td class="holds_priority">[% priority | html %] </td>
                    [% END %]

we never reach the ELSIF, we have || show_priority in the first condition.
Comment 1 Jonathan Druart 2025-10-14 09:50:01 UTC
Created attachment 187855 [details] [review]
Bug 41010: Adjust show_priority condition in opac-detail

We had
[% IF item_level_holds > 0 || show_priority %]
[% ELSIF show_priority %]

We never reach ELSIF.

I am not sure what's the correct fix here. People involved on bug 39276
should help.
Comment 2 Jonathan Druart 2025-10-14 10:07:51 UTC
Bug 39276 clashed with bug 39452.

The changes from bug 39452 was totally unrelated to the rest of the patch

-                    [% IF item_level_holds > 0 %]
+                    [% IF item_level_holds > 0 || show_priority %]

Lucas and Nick, please clarify.