From bug 39276 comment 12 I don't understand this patch. Here is the diff: + [% ELSIF show_priority %] + <td class="holds_priority">[% priority | html %] </td> [% END %] Here is the context: [% IF item_level_holds > 0 || show_priority %] <td class="holds_count"> [% IF holds_count.defined %][% ITEM_RESULT.holds_count | html %][% END %] [% IF ITEM_RESULT.priority %] [% IF holds_count.defined %] <span>(priority [% ITEM_RESULT.priority | html %])</span> [% ELSE %] <span>[% ITEM_RESULT.priority | html %]</span> [% END %] [% END %] </td> [% ELSIF show_priority %] <td class="holds_priority">[% priority | html %] </td> [% END %] we never reach the ELSIF, we have || show_priority in the first condition.
Created attachment 187855 [details] [review] Bug 41010: Adjust show_priority condition in opac-detail We had [% IF item_level_holds > 0 || show_priority %] [% ELSIF show_priority %] We never reach ELSIF. I am not sure what's the correct fix here. People involved on bug 39276 should help.
Bug 39276 clashed with bug 39452. The changes from bug 39452 was totally unrelated to the rest of the patch - [% IF item_level_holds > 0 %] + [% IF item_level_holds > 0 || show_priority %] Lucas and Nick, please clarify.
Created attachment 188027 [details] [review] Bug 41010: Adjust show_priority condition in opac-detail We had [% IF item_level_holds > 0 || show_priority %] [% ELSIF show_priority %] We never reach ELSIF. I am not sure what's the correct fix here. People involved on bug 39276 should help. Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(In reply to Jonathan Druart from comment #2) > Bug 39276 clashed with bug 39452. > > The changes from bug 39452 was totally unrelated to the rest of the patch > > - [% IF item_level_holds > 0 %] > + [% IF item_level_holds > 0 || show_priority %] > > Lucas and Nick, please clarify. If I had to guess, I was writing 39452 - then tried to help with 39276, and accidentally included an unrelated line.
Nice work everyone! Pushed to main for 25.11
Nice work everyone! Pushed to 25.05.x
Depends on Bug 39452 not in 24.11.x