To test: 1. Enable Holds history system preference and set the OPACShowHoldQueueDetails to "Show holds and their priority level". 2. Place an item on hold. 3. Log in to your OPAC and go to your Holds history tab. 4. Click on your hold that is marked as "Pending". 5. Notice that a datatable warning appears similar to: "DataTables warning: table id=holdingst - Requested unknown parameter '6' for row 0, column 6. For more information about this error, please see https://datatables.net/tn/4"
This is in main? I'm not seeing an error with any setting of OPACShowHoldQueueDetails.
(In reply to Owen Leonard from comment #1) > This is in main? I'm not seeing an error with any setting of > OPACShowHoldQueueDetails. Whoops never mind, I see it now!
This error seems to occur on "Next available" holds where there are no item specific holds on the first item shown in the holdings list for the title. Perhaps it's related to the "item hold queue priority" being blank on the first item?
There seems to be no reason to show the column at all if there are no item level holds. You shouldn't be able to mix item level and record level holds. Then we don't need to pass show_priority to the template either.
(In reply to Lucas Gass (lukeg) from comment #4) > There seems to be no reason to show the column at all if there are no item > level holds. You shouldn't be able to mix item level and record level holds. > > Then we don't need to pass show_priority to the template either. Nevermind, we pass priority when the hold is not item level: 623 $hold->itemnumber 624 ? ( $priority{ $hold->itemnumber } = $hold->priority ) 625 : ( $template->param( priority => $hold->priority ) ); We just need to show it in the template.
Created attachment 180996 [details] [review] Bug 39276: Show record level priority in opac detail page To test: 1. Enable Holds history system preference and set the OPACShowHoldQueueDetails to "Show holds and their priority level". 2. Make an item level hold on a record. 3. Make a record level hold on a different record. 4. Login to the OPAC as that patron 5. On the detail page for the item level hold, it works 6. On the detail page for the record level hold, dataTable error 7. APPLY PATCH 8. Try each of the OPAC detail pages again, they should both work.
Created attachment 181206 [details] [review] Bug 39276: Show record level priority in opac detail page To test: 1. Enable Holds history system preference and set the OPACShowHoldQueueDetails to "Show holds and their priority level". 2. Make an item level hold on a record. 3. Make a record level hold on a different record. 4. Login to the OPAC as that patron 5. On the detail page for the item level hold, it works 6. On the detail page for the record level hold, dataTable error 7. APPLY PATCH 8. Try each of the OPAC detail pages again, they should both work. Signed-off-by: David Nind <david@davidnind.com>
Testing notes: 1. Step 1 - Enable the holds history system preference: OPACHoldsHistory
Created attachment 182181 [details] [review] Bug 39276: Show record level priority in opac detail page To test: 1. Enable Holds history system preference and set the OPACShowHoldQueueDetails to "Show holds and their priority level". 2. Make an item level hold on a record. 3. Make a record level hold on a different record. 4. Login to the OPAC as that patron 5. On the detail page for the item level hold, it works 6. On the detail page for the record level hold, dataTable error 7. APPLY PATCH 8. Try each of the OPAC detail pages again, they should both work. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Pushed for 25.05! Well done everyone, thank you!