| Summary: | Checkboxes visible on the batch patron modification results view | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Tools | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | Pushed to main --- | QA Contact: | Nick Clemens (kidclamp) <nick> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | nick |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Crowdfunding goal: | 0 |
| Patch complexity: | --- | Documentation contact: | |
| Documentation submission: | Text to go in the release notes: | ||
| Version(s) released in: |
25.11.00
|
Circulation function: | |
| Bug Depends on: | 41065 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 41079: Turn on bKohaColumnsUseNames for the batch patron modification results table
Bug 41079: Force visibility for columns depending on sysprefs Bug 41079: Turn on bKohaColumnsUseNames for the batch patron modification results table Bug 41079: Force visibility for columns depending on sysprefs |
||
|
Description
Jonathan Druart
2025-10-23 08:00:26 UTC
Created attachment 188305 [details] [review] Bug 41079: Turn on bKohaColumnsUseNames for the batch patron modification results table A table cannot use the table settings if columns are displayed depending on sysprefs. Additionally DT's saveState does not work correctly if some columns are shown/hidden from one screen to another. We must add data-colname and turn bKohaColumnsUseNames on for this table. Also note that there were several discrepancies between the table structure and the number of columns in the yaml file. Created attachment 188306 [details] [review] Bug 41079: Force visibility for columns depending on sysprefs If two sysprefs are disabled we must hide the two related columns. We should also force the visibility of the checkboxes: on the first screen (op=show/edition) they must be displayed, on the result screen (op=show_results) the must be hidden. Test plan: 1. Create a report to see some patrons: SELECT cardnumber FROM borrowers WHERE cardnumber LIKE '%2' 2. Run report and select 'Batch operations ...' 3. Batch patron modification => Notice that the table has the checkboxes in the first column => The table is sorted by cardnumber 4. Perform the modification => Notice that the result table does not have the checkboxes in the first column => The table is still sorted by cardnumber Additional tests: 1. If the logged in user is superlibrarian then the columns "Password expiration date" and "Protected" are displayed 2. Play with the table's settings and columns visibility to confirm that they are working correctly (they were not before this patch set) Created attachment 188329 [details] [review] Bug 41079: Turn on bKohaColumnsUseNames for the batch patron modification results table A table cannot use the table settings if columns are displayed depending on sysprefs. Additionally DT's saveState does not work correctly if some columns are shown/hidden from one screen to another. We must add data-colname and turn bKohaColumnsUseNames on for this table. Also note that there were several discrepancies between the table structure and the number of columns in the yaml file. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 188330 [details] [review] Bug 41079: Force visibility for columns depending on sysprefs If two sysprefs are disabled we must hide the two related columns. We should also force the visibility of the checkboxes: on the first screen (op=show/edition) they must be displayed, on the result screen (op=show_results) the must be hidden. Test plan: 1. Create a report to see some patrons: SELECT cardnumber FROM borrowers WHERE cardnumber LIKE '%2' 2. Run report and select 'Batch operations ...' 3. Batch patron modification => Notice that the table has the checkboxes in the first column => The table is sorted by cardnumber 4. Perform the modification => Notice that the result table does not have the checkboxes in the first column => The table is still sorted by cardnumber Additional tests: 1. If the logged in user is superlibrarian then the columns "Password expiration date" and "Protected" are displayed 2. Play with the table's settings and columns visibility to confirm that they are working correctly (they were not before this patch set) Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Straightforward, moving to PQA Nice work everyone! Pushed to main for 25.11 |