| Summary: | 'No budget defined' showing up although budgets and funds are defined | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
| Component: | Acquisitions | Assignee: | Katrin Fischer <katrin.fischer> |
| Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
| Severity: | normal | ||
| Priority: | PATCH-Sent (DO NOT USE) | CC: | koha.sekjal, paul.poulain, wizzyrea |
| Version: | 3.6 | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 23318, 5072, 24111 | ||
| Attachments: |
screenshot of error message
Bug 6994: Wrong 'no budget defined' alert Bug 6994: Wrong 'no budget defined' alert |
||
Note: CCL parsing error showed up because I had searched for '5)' - known problem. Created attachment 6044 [details] [review] Bug 6994: Wrong 'no budget defined' alert When ordering from an existing record the 'no budgets and funds defined' error message was shown below the result list. To test: A) No budgets defined for this user and library Basket summary page shows a warning instead of the link for creation of orders. B) Budgets and funds are properly defined for this user and library Basket summary page shows links for order creation. Before patch: A search for an existing record had the alert at the bottom of the search result list. After patch: The links for creation of orders are shown instead. Created attachment 6101 [details] [review] Bug 6994: Wrong 'no budget defined' alert When ordering from an existing record the 'no budgets and funds defined' error message was shown below the result list. To test: A) No budgets defined for this user and library Basket summary page shows a warning instead of the link for creation of orders. B) Budgets and funds are properly defined for this user and library Basket summary page shows links for order creation. Before patch: A search for an existing record had the alert at the bottom of the search result list. After patch: The links for creation of orders are shown instead. Signed-off-by: Liz Rea <lrea@nekls.org> Verified A and B. Implements this check consistently, using the same structure as acqui/basket.pl Use of GetMember instead of GetMemberDetails keeps it as lean as possible. Marking as Passed QA. Patch pushed, please test This fix was included in the 3.6.x branch prior to 3.6.4. |
Created attachment 5815 [details] screenshot of error message You can't create any orders unless you first define a budget and a fund. Information to reproduce: - budget and funds are defined - ordering in general works - warning shows up when search for existing record from basket gives no results