Bug 10102 - don't show empty novelist tab if no data
Summary: don't show empty novelist tab if no data
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-23 15:24 UTC by Nicole C. Engard
Modified: 2019-10-14 19:56 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2013-04-23 15:24:51 UTC
If you're using Novelist and have the data showing in a tab you see an empty tab for items not found in Novelist - videos specifically. The tab should be hidden if empty.
Comment 1 Nick Clemens 2015-11-18 17:13:33 UTC
Tricky with the fact that Novelist is all js and loaded after the page, but adding the below to OPACUserJS seems to accomplish it.  Something cleaner would be nice but this works as a quick fix:

$(window).load(function(){
if( !$('#NovelistSelect').find('img').length ){
$("a[href=#NovelistSelect]").remove();
$("#NovelistSelect").remove();
}
});
Comment 2 Patricia Brauer 2016-08-05 21:42:30 UTC
Nick-
Sorry ignore my comment. Having browser problems. Tricia B.
Comment 3 Owen Leonard 2018-06-29 13:54:57 UTC
In my tests this has been resolved--presumably on the Novelist side of things. If anyone finds otherwise please re-open with additional details.