Bug 10153 - Patron header search form is too wide
Summary: Patron header search form is too wide
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-29 16:47 UTC by Owen Leonard
Modified: 2013-12-05 20:09 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Screenshot showing the patron header search form layout problem (18.52 KB, image/png)
2013-04-29 16:47 UTC, Owen Leonard
Details
Bug 10153 - Patron header search form is too wide (5.91 KB, patch)
2013-04-29 18:31 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 10153 - Patron header search form is too wide (5.96 KB, patch)
2013-04-29 18:34 UTC, Nicole C. Engard
Details | Diff | Splinter Review
[PASSED QA] Bug 10153 - Patron header search form is too wide (6.07 KB, patch)
2013-04-29 21:01 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2013-04-29 16:47:28 UTC
Created attachment 17807 [details]
Screenshot showing the patron header search form layout problem

The patron header search form (as seen for instance on members/members-home.pl) is too wide for browsers windows narrower than about 1110px. Some or all of the search options should be hidden by default in order to make the layout work better.
Comment 1 Owen Leonard 2013-04-29 18:31:27 UTC Comment hidden (obsolete)
Comment 2 Nicole C. Engard 2013-04-29 18:34:05 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2013-04-29 21:01:01 UTC
Created attachment 17823 [details] [review]
[PASSED QA] Bug 10153 - Patron header search form is too wide

The patron header search form is now too wide to display correctly on
screens smaller than about 1110px. This patch groups the
previously shown-by-default choices with the hidden additional
search parameters.

To test, apply the patch and view any page which includes the patron
header search include, for example members/members-home.pl. Additional
search options should be hidden by default. Clicking "[+]" should show
all additional options: Search fields, search type, order by, library,
and category.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Works for me.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes all tests and QA script. I like this change.
Comment 4 Katrin Fischer 2013-04-29 21:05:58 UTC
Patch seems to work fine, but there is something annoying about patron search. Student and library remember the value after sending the search - but Search fields, Search type and Order by revert to default. I will file a separate bug.
Comment 5 Nicole C. Engard 2013-04-30 12:43:42 UTC
I think there is already another report for that issue - I think I reported it :)
Comment 6 Jared Camins-Esakov 2013-05-01 10:24:03 UTC
This patch has been pushed to master and 3.12.x.
Comment 7 Chris Cormack 2013-05-08 07:45:30 UTC
Pushed to 3.10.x will be in 3.10.6