Created attachment 17807 [details] Screenshot showing the patron header search form layout problem The patron header search form (as seen for instance on members/members-home.pl) is too wide for browsers windows narrower than about 1110px. Some or all of the search options should be hidden by default in order to make the layout work better.
Created attachment 17813 [details] [review] Bug 10153 - Patron header search form is too wide The patron header search form is now too wide to display correctly on screens smaller than about 1110px. This patch groups the previously shown-by-default choices with the hidden additional search parameters. To test, apply the patch and view any page which includes the patron header search include, for example members/members-home.pl. Additional search options should be hidden by default. Clicking "[+]" should show all additional options: Search fields, search type, order by, library, and category.
Created attachment 17814 [details] [review] [SIGNED-OFF] Bug 10153 - Patron header search form is too wide The patron header search form is now too wide to display correctly on screens smaller than about 1110px. This patch groups the previously shown-by-default choices with the hidden additional search parameters. To test, apply the patch and view any page which includes the patron header search include, for example members/members-home.pl. Additional search options should be hidden by default. Clicking "[+]" should show all additional options: Search fields, search type, order by, library, and category. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Works for me.
Created attachment 17823 [details] [review] [PASSED QA] Bug 10153 - Patron header search form is too wide The patron header search form is now too wide to display correctly on screens smaller than about 1110px. This patch groups the previously shown-by-default choices with the hidden additional search parameters. To test, apply the patch and view any page which includes the patron header search include, for example members/members-home.pl. Additional search options should be hidden by default. Clicking "[+]" should show all additional options: Search fields, search type, order by, library, and category. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Works for me. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. I like this change.
Patch seems to work fine, but there is something annoying about patron search. Student and library remember the value after sending the search - but Search fields, Search type and Order by revert to default. I will file a separate bug.
I think there is already another report for that issue - I think I reported it :)
This patch has been pushed to master and 3.12.x.
Pushed to 3.10.x will be in 3.10.6