Bug 10176 - Invalid URLs in 'Refine Search Results' when it uses UNICODE symbols
Summary: Invalid URLs in 'Refine Search Results' when it uses UNICODE symbols
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: 3.12
Hardware: All All
: P5 - low major (vote)
Assignee: Karam Qubsi
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-02 14:26 UTC by Karam Qubsi
Modified: 2013-12-05 20:09 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Solve-the-Invalid-URLs-in-Refine-Search-Results (893 bytes, patch)
2013-05-04 21:11 UTC, Karam Qubsi
Details | Diff | Splinter Review
[SIGNED-OFF] Bug-10176 Solve the Invalid URLs in 'Refine Search Results' when it uses UNICODE symbols (1.01 KB, patch)
2013-05-05 01:53 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
[PASSED QA] Bug 10176: Solve the Invalid URLs in 'Refine Search Results' when it uses UNICODE symbols (1.27 KB, patch)
2013-05-05 11:19 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Karam Qubsi 2013-05-02 14:26:31 UTC
When we have list of results with UNICODE symbols, like Arabic or other 
The URLs in the 'Refine Search' is looks like this : 

http://5.0.85.204:75/cgi-bin/koha/opac-search.pl?idx=kw&q=ﻣﻜﺘﺐ&sort_by=relevance_dsc&limit=au: �� ي � ي ﻟﻮ� � � � .

so no results when click on.
Comment 1 Karam Qubsi 2013-05-04 21:11:26 UTC Comment hidden (obsolete)
Comment 2 Bernardo Gonzalez Kriegel 2013-05-05 01:53:14 UTC Comment hidden (obsolete)
Comment 3 Bernardo Gonzalez Kriegel 2013-05-05 02:48:38 UTC
Also works on master
Comment 4 Katrin Fischer 2013-05-05 11:19:00 UTC
Created attachment 17954 [details] [review]
[PASSED QA] Bug 10176: Solve the Invalid URLs in 'Refine Search Results' when it uses UNICODE symbols

I just add use utf8; to the Search.pm and the problem
was solved .

Test plan :
1- Add bib records with non-latin characters
2- search for some of these records
3- try to refine your search using Subject / Author

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>

Comment: Work fixing URLs in facets. Now they work correctly.
No errors.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes all tests and QA script.

I tested facets with the 22 Arabic records provided on
bug 9579 successfully. Before the patch the links are not
correct, after applying the patch the links work as
expected.
Comment 5 Jared Camins-Esakov 2013-05-06 12:23:29 UTC
This patch has been pushed to master and 3.12.x.

This problem actually occurs only with Arabic characters as far as I can tell- Cyrillic works fine even without the patch.
Comment 6 Chris Cormack 2013-05-10 23:21:38 UTC
Pushed to 3.10.x and explained what use utf8; does

Will be in 3.10.6