Bug 10236 - software error greek authorities
Summary: software error greek authorities
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: 3.8
Hardware: All All
: P5 - low minor (vote)
Assignee: Fridolin Somers
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-13 14:42 UTC by Fridolin Somers
Modified: 2014-12-07 20:02 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
[3.8.x] proposed patch (2.44 KB, patch)
2013-05-13 15:10 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 10236 - software error greek authorities (2.49 KB, patch)
2013-07-14 07:00 UTC, Chris Cormack
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2013-05-13 14:42:32 UTC
When displaying at OPAC an authority containing several languages forms, we get a software error :
Template process failed: file error - language: not found at /home/fsomers/workspace/versions/community_38/C4/Templates.pm line 127.
Comment 1 Fridolin Somers 2013-05-13 15:10:23 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2013-07-14 07:00:45 UTC
Created attachment 19616 [details] [review]
Bug 10236 - software error greek authorities

When displaying at OPAC an authority containing several languages forms, we get a software error.

There is in authority template page a call to "language" function but this function does not exist.
This patch copies behaviour from bug 8870 (pushed in 3.10) which introduces the "language function".

Test plan (unimarc) :
- create an authority with 2 fields 700 with :
700$7 ba0yga0y
   $8 fregrc
   $a Κίνναμος

700$7 ba0yba0a
   $8 frefre
   $a Cinnamos

- display this authority at OPAC
=> you should see :
See also Greek term: Κίνναμος
See also French term: Cinnamos

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Comment 3 Marcel de Rooy 2013-08-19 11:00:29 UTC
QA Comment:
Could not get this to apply in an older 3.8 install (that I did not want to upgrade for this reason).
But the 'code' looks good to me. It corrects a trivial typo in a variable name.

Setting the status to Pushed to Stable to get attention of Rmaint 3.8.