The BorrowerMandatoryField pref should have categorycode and branchcode should be in the default values for this preference since they are required by Koha but not labeled as such on the patron add form. Nicole
(In reply to comment #0) > The BorrowerMandatoryField pref should have categorycode and branchcode I would think instead they should be mandatory regardless of what is in BorrowerMandatoryField.
That works for me too :) Anything that makes it clear that they're required. Nicole
Created attachment 18825 [details] [review] Bug 10297 - categorycode and branchcode should be required when adding patrons categorycode and branchcode should show as required under all circumstances, not just when they are included in the BorrowerMandatoryField system preference. This patch adds the correct classes and hints to those fields. To test, view the patron entry form for a new or existing patron. Category and Library should show that they are required.
Created attachment 18828 [details] [review] [SIGNED OFF] Bug 10297 - categorycode and branchcode should be required when adding patrons categorycode and branchcode should show as required under all circumstances, not just when they are included in the BorrowerMandatoryField system preference. This patch adds the correct classes and hints to those fields. To test, view the patron entry form for a new or existing patron. Category and Library should show that they are required. Signed-off-by: David Cook <dcook@prosentient.com.au> Works as described.
QA comment: Logical patch, branchcode and categorycode cannot be null. Marked as Passed QA.
Pushed to master. Thanks, Owen!
This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks for reporting Nicole, and Owen for the fix!
Pushed to 3.10.x, will be in 3.10.8
Pushed to 3.8.x, will be in 3.8.15