Bug 10304 - Add avanced search filter for "not for loan" items
Summary: Add avanced search filter for "not for loan" items
Status: Failed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Searching (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Kyle M Hall
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-21 19:48 UTC by Kyle M Hall
Modified: 2018-10-22 08:55 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 10304 - Filter notforloan items when searching for only available items (2.03 KB, patch)
2013-05-21 19:51 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 10304 - Add avanced search filter for "not for loan" items (5.36 KB, patch)
2013-05-23 14:09 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2013-05-21 19:48:17 UTC
It does not make sense for the "available items only" search limit to include results for items that are not for loan.
Comment 1 Kyle M Hall 2013-05-21 19:51:38 UTC Comment hidden (obsolete)
Comment 2 Katrin Fischer 2013-05-22 06:16:59 UTC
Kyle, sorry, but I disagree here. As I understand it available does not necessarily imply that you can check the item out, but that it's currently available (on the shelf) in the library.
Comment 3 Kyle M Hall 2013-05-23 14:09:39 UTC
Created attachment 18350 [details] [review]
Bug 10304 - Add avanced search filter for "not for loan" items

This patch adds a new search limit for not for loan items. This limit
filters all items that have a notforloan value not equal to 0. This
limit can be used in conjunction with the "available" limit so that
a person may search for items that are available and can be checked out
right away.

Test Plan:
1) Apply this patch
2) Catalog 3 records with 1 item each.
   a) Mark item A as notforloan
   b) Mark item B as lost
   c) Do nothing to item C
3) Do a search limiting only to available items
   a) You should see item's A and C in your reults
4) Do a search limiting only to items that can be checked out
   a) You should see item's B and C
5) Do a seach using both limits
   a) You should see item C and not items A or B
Comment 4 Kyle M Hall 2013-05-23 14:19:59 UTC
Ok, I've updated my patch to make it a new optional filter that may be used in conjunction with the existing availability filter.

(In reply to comment #2)
> Kyle, sorry, but I disagree here. As I understand it available does not
> necessarily imply that you can check the item out, but that it's currently
> available (on the shelf) in the library.
Comment 5 Katrin Fischer 2013-05-23 14:44:02 UTC
Comment on attachment 18350 [details] [review]
Bug 10304 - Add avanced search filter for "not for loan" items

"Only items that can be checked out" seems a bit dangerous for me as a lot of our libraries allow some patron categories to checkout several itemtypes while others are not allowe. So almost no items are marked 'reference'. It's not possible to create a filter that will take into account circulation rules and for some libraries this will work - also it has an id so it can be hidden. But I am still a little worried we will see bug reports about that not working like people expect it.
Comment 6 Marie-Laure Meunier 2013-06-25 16:00:28 UTC
After testing the patch during the koha symposium in Limoges, the result is not positive when the filter is selected. There is no result even if the items are available for loan.
Comment 7 Mirko Tietgen 2013-07-27 23:12:20 UTC
After reading the comments I am changing this to enhancement as it does not seem to be considered a bug fix anymore but a new option. Please change it back if that is incorrect.
Comment 8 Owen Leonard 2013-07-31 13:52:04 UTC
This patch appears to break the "only available" option, whether it is used on its own or in conjunction with the new "only for loan" option. I get no results for a search which should return available items.
Comment 9 Marc Véron 2016-05-23 15:58:00 UTC
Still valid?