Bug 10319 - C4::SocialData is badly named
Summary: C4::SocialData is badly named
Status: CLOSED WONTFIX
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Galen Charlton
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-23 16:34 UTC by Galen Charlton
Modified: 2020-01-06 20:14 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Galen Charlton 2013-05-23 16:34:20 UTC
The name of the module implies that it supports general-purpose social (network?) data handling.  It does not; the code is applicable only to a particular added content vendor, Babeltheque, and the module should be renamed accordingly, for example, to C4::External::Babeltheque (or better, if it meets the criteria, Koha::External::Babeltheque).

Similarly, the following directories and cronjobs should be renamed:

./misc/cronjobs/social_data
./misc/cronjobs/social_data/update_social_data.pl
./misc/cronjobs/social_data/get_report_social_data.pl
Comment 1 Jonathan Druart 2014-03-05 10:39:57 UTC
The C4::SocialData module is not specific to Babeltheque.
The only specific script is misc/cronjobs/social_data/update_social_data.pl
I developed the SocialData module in order it may used by another content vendor.
The only thing to do is to call update_data with a csv file containing different values (number of critic, number of videos, etc.).
Comment 2 Katrin Fischer 2019-05-04 21:34:16 UTC
(In reply to Jonathan Druart from comment #1)
> The C4::SocialData module is not specific to Babeltheque.
> The only specific script is misc/cronjobs/social_data/update_social_data.pl
> I developed the SocialData module in order it may used by another content
> vendor.
> The only thing to do is to call update_data with a csv file containing
> different values (number of critic, number of videos, etc.).

Marking WONTFIX, please reopen if you disagree.