Bug 10418 - Correct template markup problems on course reserves add item page
Summary: Correct template markup problems on course reserves add item page
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact:
URL: /cgi-bin/koha/course_reserves/add_ite...
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-05 13:36 UTC by Owen Leonard
Modified: 2014-12-07 20:03 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 10418 - Correct template markup problems on course reserves add item page (18.72 KB, patch)
2013-06-05 14:05 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 10418 - Correct template markup problems on course reserves add item page (18.79 KB, patch)
2013-06-07 12:52 UTC, Jared Camins-Esakov
Details | Diff | Splinter Review
Bug 10418 - Correct template markup problems on course reserves add item page (18.89 KB, patch)
2013-06-14 17:05 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2013-06-05 13:36:34 UTC
There are issues with validity and consistency on the course reserves add item page.
Comment 1 Owen Leonard 2013-06-05 14:05:29 UTC Comment hidden (obsolete)
Comment 2 Jared Camins-Esakov 2013-06-07 12:52:33 UTC Comment hidden (obsolete)
Comment 3 Kyle M Hall 2013-06-14 17:05:10 UTC
Created attachment 19020 [details] [review]
Bug 10418 - Correct template markup problems on course reserves add item page

This patch corrects several problems with the course reserves add item
pages:

- Non-standard grid markup.
- Extra </div>.
- Incorrect styling of errors and messages.
- Redundant JS for adding focus to a field (use "focus" class).
- Invalid use of <label> with no corresponding input (use <span
  class="label"> instead).
- Incorrect capitalization.

To test, apply the patch and examing both steps of the process of adding
an item to an existing course: The initial "scan barcode" form, and the
form for editing details of a scanned item.

Some cases to check:

- Scan an invalid barcode.
- Scan a barcode which has already been added to a course.
- Scan a barcode wihch has already been added to the course you're
  working with.

Forms should look correct and work correctly.

This patch contains whitespace changes, so please ignore whitespace when
examining changes.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
The add item screen continues to work as before.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Passes koha-qa.pl. Works as advertised.
Comment 4 Galen Charlton 2013-06-14 18:25:11 UTC
Pushed to master.  Thanks, Owen!