I'm not disputing the test itself, but wouldn't it be nice if AddShare returned something to indicate sucsess/failure?

(In reply to comment #2)
> I'm not disputing the test itself, but wouldn't it be nice if AddShare
> returned something to indicate sucsess/failure?

Thanks for testing.
First of all, you are right of course.
By far, we are not testing the success of mysql insert statements in Koha. In some cases it is done (saw one when e.g. adding a biblio); note that AddShare is not the most critical operation :) AddShare could however simply check DBI's err and return a boolean.
Will leave the two reports as they are now for the moment, but will later handle this in a followup.

See also report 10499. This patch removed the DelShelf code. Will include it again in rebasing this patch.

Just an idea, maybe use SKIP block rather than if().

(In reply to Srdjan Jankovic from comment #7)
> Just an idea, maybe use SKIP block rather than if().

Thanks for testing, Srdjan.
Yes, could have used skip here too. Can imagine cases where skip would really be a better choice. In this case fairly arbitrary..

Quick review:

Please prefer "is" instead of "ok":

  ok(1 == $status, "deleted shelf $shelfnumber and its contents");
  is( $status, 1, "deleted shelf $shelfnumber and its contents");

and
  for my $i ( 0 .. 9 ) {
instead of
  for(my $i=0; $i<10;$i++){

Patch this depends on is currently 'failed qa' - using blocked to indicate that this can't be QA'd right now.

I will move this code to bug 9032.
Close this report now.