Bug 10445 - SIP Server doesn't respect maxoutstanding system preference
Summary: SIP Server doesn't respect maxoutstanding system preference
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: SIP2 (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Kyle M Hall
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 10446
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-11 14:00 UTC by Kyle M Hall
Modified: 2015-06-04 23:23 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 10445 - SIP Server doesn't respect maxoutstanding system preference (1.33 KB, patch)
2013-06-11 14:03 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 10445 - SIP Server doesn't respect maxoutstanding system preference (2.00 KB, patch)
2013-06-11 14:04 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 10445 - SIP Server doesn't respect maxoutstanding system preference (2.04 KB, patch)
2013-06-24 08:28 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 10445 - SIP Server doesn't respect maxoutstanding system preference - QA Followup (720 bytes, patch)
2013-10-21 00:28 UTC, Kyle M Hall
Details | Diff | Splinter Review
[PASSED-QA] Bug 10445 - SIP Server doesn't respect maxoutstanding system preference (2.12 KB, patch)
2013-10-21 00:58 UTC, Brendan Gallagher
Details | Diff | Splinter Review
[PASSED-QA] Bug 10445 - SIP Server doesn't respect maxoutstanding system preference (2.12 KB, patch)
2013-10-21 01:00 UTC, Brendan Gallagher
Details | Diff | Splinter Review
[PASSED-QA] Bug 10445 - SIP Server doesn't respect maxoutstanding system preference - QA Followup (827 bytes, patch)
2013-10-21 01:00 UTC, Brendan Gallagher
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2013-06-11 14:00:47 UTC
The system preference 'maxoutstanding' is defined as the maximum amount of fees owed by the patron before Koha should block placing holds ( terrible naming on this one ).

However, although the Koha OPAC respects this preference, placing holds via a SIP2 device will not.
Comment 1 Kyle M Hall 2013-06-11 14:03:32 UTC Comment hidden (obsolete)
Comment 2 Kyle M Hall 2013-06-11 14:04:28 UTC Comment hidden (obsolete)
Comment 3 Chris Cormack 2013-06-24 08:28:32 UTC Comment hidden (obsolete)
Comment 4 Katrin Fischer 2013-07-07 11:22:19 UTC
Who on the QA team (except for Chris and Kyle) knows how to test SIP or can teach me?
Comment 5 Katrin Fischer 2013-09-08 11:17:03 UTC
Hi Kyle,
I am working on testing the SIP2 patches - it would speed things up quite a bit if you could provide me with a test script or some example SIP messages for placing holds. For an example of a test script see bug 10817.
Comment 6 Brendan Gallagher 2013-10-20 23:17:39 UTC
 FAIL   C4/SIP/ILS.pm
   OK     pod
   OK     forbidden patterns
   FAIL   valid
                Compilation failed in require 
                Global symbol "$self" requires explicit package name 
   OK     critic

 FAIL   C4/SIP/ILS/Patron.pm
   OK     pod
   OK     forbidden patterns
   FAIL   valid
                C4/SIP/ILS/Patron.pm had compilation errors.
                Global symbol "$self" requires explicit package name 
   OK     critic
Comment 7 Kyle M Hall 2013-10-21 00:28:10 UTC Comment hidden (obsolete)
Comment 8 Brendan Gallagher 2013-10-21 00:58:02 UTC Comment hidden (obsolete)
Comment 9 Brendan Gallagher 2013-10-21 01:00:10 UTC
Created attachment 22146 [details] [review]
[PASSED-QA] Bug 10445 - SIP Server doesn't respect maxoutstanding system preference

The system preference 'maxoutstanding' is defined as the maximum amount
of fees owed by the patron before Koha should block placing holds (
terrible naming on this one ).

However, although the Koha OPAC respects this preference, placing holds
via a SIP2 device will not.

Test Plan:
1) Set maxoutstanding to $10
2) Pick a patron owning more than $10 in fees
3) Attempt to place a hold for this patron from a SIP2 device
   This attempt should succeed
4) Apply this patch
5) Restart your SIP2 server
6) Attempt to place a hold for this patron from a SIP2 device again
   This attempt should now fail

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Comment 10 Brendan Gallagher 2013-10-21 01:00:19 UTC
Created attachment 22147 [details] [review]
[PASSED-QA] Bug 10445 - SIP Server doesn't respect maxoutstanding system preference - QA Followup

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>

Followup to failed QA tests have helped pass.
Comment 11 Galen Charlton 2013-10-31 18:06:35 UTC
Pushed to master.  Thanks, Kyle!
Comment 12 Tomás Cohen Arazi 2013-12-05 18:27:43 UTC
This patch has been pushed to 3.12.x, will be in 3.12.8.

Thanks Kyle!