Bug 10451 - Firefox prints only first page of table with shrink to fit option
Summary: Firefox prints only first page of table with shrink to fit option
Status: In Discussion
Alias: None
Product: Koha
Classification: Unclassified
Component: Browser compatibility (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-12 13:52 UTC by Dobrica Pavlinusic
Modified: 2016-12-01 21:57 UTC (History)
8 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 10451 - Firefox prints only first page of table with shrink to fit option (1.19 KB, patch)
2013-06-12 15:02 UTC, Dobrica Pavlinusic
Details | Diff | Splinter Review
Bug 10451 - Firefox prints only first page of table with shrink to fit option (1.32 KB, patch)
2013-06-14 13:02 UTC, Dobrica Pavlinusic
Details | Diff | Splinter Review
Bug 10451 - Firefox prints only first page of table with shrink to fit option (1.36 KB, patch)
2014-01-09 08:04 UTC, Chris Cormack
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Dobrica Pavlinusic 2013-06-12 13:52:35 UTC

    
Comment 1 Dobrica Pavlinusic 2013-06-12 15:02:51 UTC Comment hidden (obsolete)
Comment 2 Kyle M Hall 2013-06-14 11:13:12 UTC
Dobrica, since this causes wasted space, would it be better to make this css affect only firefox like this?

@-moz-document url-prefix() {
    table {
        /* tries to fix firefox 21+ shrink-to-fit */
        page-break-inside: avoid;
    }
}
Comment 3 Dobrica Pavlinusic 2013-06-14 13:01:28 UTC
Kyle, thanks for suggestion. If would be better to affect just Firefox, I will re-submit patch with your fix.
Comment 4 Dobrica Pavlinusic 2013-06-14 13:02:02 UTC Comment hidden (obsolete)
Comment 5 Srdjan Jankovic 2013-07-26 03:55:02 UTC
Do we need to test this?
Comment 6 I'm just a bot 2013-09-29 05:32:34 UTC
Patch applied cleanly, go forth and signoff
Comment 7 I'm just a bot 2013-10-30 07:38:17 UTC
Patch applied cleanly, go forth and signoff
Comment 8 Nicole C. Engard 2014-01-08 20:55:36 UTC
Can we have a test plan? A page with a table we should look at to see it before and after?
Comment 9 Chris Cormack 2014-01-09 08:04:13 UTC
Created attachment 24049 [details] [review]
Bug 10451 - Firefox prints only first page of table with shrink to fit option

According to Firefox bug tracker, versions up to 21 doesn't print
tables correctly when using shrink to fit option. See:

https://bugzilla.mozilla.org/show_bug.cgi?id=684622

However, even with v21 or newer, we still need to add css to
print media which instruct it not to break table tag to print
all pages of table. This has a side-effect that table starts
always on next page, wasting some space on first printed page
(but only in Firefox since CSS selector is specific to it).

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Comment 10 Katrin Fischer 2014-01-11 20:57:38 UTC
I tried this with Firefox 26 in Ubuntu for a result page in staff and a very full cart. Without the patch, the pages prints nicely. With the patch, we have the navigation on the first page and the rest on the second.

This is quite a regression in newer Firefox versions.

I hesitate to pass QA on this.
Comment 11 Owen Leonard 2016-02-20 22:35:05 UTC
Two years later is this still an issue? It isn't in my tests.
Comment 12 Billy 2016-07-25 20:39:23 UTC
i figured i should chime in here because i have been having this problem for years. The only time i try to print something in Firefox is when Google Chrome won't print my class schedule and i think the problems are related. In Chrome, Safari, and Opera the printout and print preview is all goofy looking. It has shrunken frames and visible scrollbars and is unusable. And it is like this on every computer i try it on.

So i always try to do it in Firefox, but i always get this problem where Firefox will only print the first page!

Whatever HTML my school's website is using for displaying both regular class schedule and a "printable" version of the class schedule isn't rendering properly for these browsers.

And i have to say it is SUPER annoying. I end up just printing screenshots.