When editing frameworks you have to click 'display more' to see the hidden values and others. I don't think we need to make this collapsed and require clicking to see more. But if others feel that we do need it I'd like a way to have it remember that I showed more on the previous subfield so that I don't have to click it over and over for every subfield on a tag.
Does this bug refer to the process of editing a subfield structure? /cgi-bin/koha/admin/marc_subfields_structure.pl?op=add_form&tagfield=XXX&frameworkcode=XXX If so I agree. I don't know why we couldn't just show the whole form.
Yes, that's the URL.
I think while the accordeon is nice the process might be sped up by showing more information by default.
Created attachment 96287 [details] [review] Bug 10469: Display more when editing subfields in frameworks This patch removes the accordion feature from the MARC subfields structure editor. The form is not long, and I think in this case the accordion makes the process more difficult to navigate. To test, apply the patch and go to Administration -> MARC frameworks -> Framework structure -> Subfield structure -> Edit. Choose a tag with multiple subfields to best test the changes. The whole form should apppear, and tabs functionality should work correctly. Test that making changes under multiple tabs works correctly.
Created attachment 96690 [details] [review] Bug 10469: Display more when editing subfields in frameworks This patch removes the accordion feature from the MARC subfields structure editor. The form is not long, and I think in this case the accordion makes the process more difficult to navigate. To test, apply the patch and go to Administration -> MARC frameworks -> Framework structure -> Subfield structure -> Edit. Choose a tag with multiple subfields to best test the changes. The whole form should apppear, and tabs functionality should work correctly. Test that making changes under multiple tabs works correctly. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 96738 [details] [review] Bug 10469: Display more when editing subfields in frameworks This patch removes the accordion feature from the MARC subfields structure editor. The form is not long, and I think in this case the accordion makes the process more difficult to navigate. To test, apply the patch and go to Administration -> MARC frameworks -> Framework structure -> Subfield structure -> Edit. Choose a tag with multiple subfields to best test the changes. The whole form should apppear, and tabs functionality should work correctly. Test that making changes under multiple tabs works correctly. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Nice work everyone! Pushed to master for 20.05
Pushed to 19.11.x branch for 19.11.02
backported to 19.05.x for 19.05.07
Enhancement will not be backported to 18.11.x series.