Bug 10521 - Add i18n function to German mysql files for webinstaller (de-DE)
Summary: Add i18n function to German mysql files for webinstaller (de-DE)
Status: CLOSED WONTFIX
Alias: None
Product: Koha
Classification: Unclassified
Component: Installation and upgrade (web-based installer) (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Marcel de Rooy
QA Contact:
URL:
Keywords:
Depends on: 10509 10520
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-01 10:52 UTC by Marcel de Rooy
Modified: 2016-11-04 11:25 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 10521: Prepare de-DE mandatory sql files for conversion (4.82 KB, patch)
2013-08-08 13:17 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 10521: Define i18n function for de-DE/mandatory files (109.89 KB, patch)
2013-08-08 13:17 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 10521: Prepare de-DE optional sql files for conversion (9.76 KB, patch)
2013-08-08 13:17 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 10521: Define i18n function for de-DE/optional files (89.50 KB, patch)
2013-08-08 13:17 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 10521: Followup for relator terms and quotes (30.16 KB, patch)
2013-08-08 13:17 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 10521: Prepare de-DE marc21/optional files for conversion (3.49 KB, patch)
2013-08-08 13:17 UTC, Marcel de Rooy
Details | Diff | Splinter Review
[PATCH_IN_GZ] Bug 10521: Define i18n function for de-DE/marc21/mandatory (221.12 KB, application/x-gzip)
2013-08-08 13:25 UTC, Marcel de Rooy
Details
[PATCH_IN_GZ] Bug 10521: Define i18n function for de-DE/marc21/optional (871.84 KB, application/x-gzip)
2013-08-08 13:27 UTC, Marcel de Rooy
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2013-07-01 10:52:02 UTC
See bug 10509 and bug 10520.
Followup for German.
Comment 1 Marcel de Rooy 2013-08-08 13:17:34 UTC
Created attachment 20166 [details] [review]
Bug 10521: Prepare de-DE mandatory sql files for conversion

Makes some manual changes to .sql files before converting them to new format
for use with i18n function.

Sample notices: remove newline between last quote and );
Stopwords: Add column name
Userflags: Convert into one insert statement with multiple values

Test plan:
See second patch for de-DE mandatory files.
Comment 2 Marcel de Rooy 2013-08-08 13:17:40 UTC
Created attachment 20167 [details] [review]
Bug 10521: Define i18n function for de-DE/mandatory files

This patch adjusts the de-DE/mandatory files.

Test plan:
Run German install, including all mandatory files.
Check translated strings from several tables touched in Mandatory.
Comment 3 Marcel de Rooy 2013-08-08 13:17:45 UTC
Created attachment 20168 [details] [review]
Bug 10521: Prepare de-DE optional sql files for conversion

Makes some manual changes to .sql files before converting them to new format
for use with i18n function.

Sample creator data: Remove lock statements, add column names
Sample holidays: Add column names
Sample itemtypes: Convert into one insert statement with multiple values
Sample news: Add column name

Test plan:
See next patch for de-DE optional files.
Comment 4 Marcel de Rooy 2013-08-08 13:17:50 UTC
Created attachment 20169 [details] [review]
Bug 10521: Define i18n function for de-DE/optional files

This patch adjusts the de-DE/optional files.

Test plan:
Run German install, including all optional files.
Check translated strings from several tables touched in Optional.
Comment 5 Marcel de Rooy 2013-08-08 13:17:55 UTC
Created attachment 20170 [details] [review]
Bug 10521: Followup for relator terms and quotes

These files were still missing in the German install.

Test plan:
Select relator terms and quotes in German optional install.
Since nothing is translated yet, you should see English strings.
Comment 6 Marcel de Rooy 2013-08-08 13:17:59 UTC
Created attachment 20171 [details] [review]
Bug 10521: Prepare de-DE marc21/optional files for conversion

Makes some manual changes to .sql files before converting them to new format
for use with i18n function.

Default matching rules: added only some comment lines to skip a few
INSERT..SELECT constructs during conversion.
Fastadd framework: Add column names.

Test plan:
See next patch for de-DE marc21/optional files.
Comment 7 Marcel de Rooy 2013-08-08 13:25:56 UTC
Created attachment 20172 [details]
[PATCH_IN_GZ] Bug 10521:  Define i18n function for de-DE/marc21/mandatory

Patch in zipped attachment
Comment 8 Marcel de Rooy 2013-08-08 13:27:15 UTC
Created attachment 20173 [details]
[PATCH_IN_GZ]  Bug 10521: Define i18n function for de-DE/marc21/optional

Patch zipped in attachment
Comment 9 I'm just a bot 2013-09-29 05:35:47 UTC
Patch applied cleanly, go forth and signoff
Comment 10 Marcel de Rooy 2013-10-24 08:43:23 UTC
dep. 10520 does not apply
Comment 11 Josef Moravec 2016-11-04 11:25:04 UTC
Both dependencies are CLOSED WONTFIX