In parcels.pl, and other acquisition pages, the funds are not sorted by name in combo-box. With a great number of founds, it is difficult to find one.
Created attachment 19365 [details] [review] Proposed patch See commit message
Patch tested with a sandbox, by Silvia Simonetti <s.simonetti@cineca.it>
Created attachment 19402 [details] [review] [SIGNED-OFF] Bug 10535 - by default sort funds by name Something went wrong with sandbox, I created signed patch.
Created attachment 19539 [details] [review] [PASSED QA] Bug 10535 - by default sort funds by name In parcels.pl, and other acquisition pages, the funds are not sorted by name in combo-box. With a great number of funds, it is difficult to find one. This patch adds a default value to $orderby arg of C4::Budgets::GetBudgets. Test plan : - Create a new fund with a name beginning with 'z' and set you as owner. - Create a new fund with a name beginning with 'a' and set you as owner. - Go to a vendor and click "Receive shipments" - Look at fund combobox => Funds are sorted by name Signed-off-by: Silvia Simonetti <s.simonetti@cineca.it> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. When testing make sure your funds would sort the other way around when sorting by code instead of description.
Pushed to master. Thanks, Fridoyn!
Created attachment 19579 [details] [review] Bug 10535: (follow-up) add test case This adds a test case for the new default sort order for GetBudgets(). Signed-off-by: Galen Charlton <gmc@esilibrary.com>
I've attached a follow-up patch that adds a test case for the change to the default sort order. I very much prefer that *all* changes to routines in C4 and Koha be accompanied by test cases. Note that in order for this patch to apply cleanly, the patch for bug 10577 must be applied first.
The first patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Fridolyn!
(In reply to Galen Charlton from comment #7) > I've attached a follow-up patch that adds a test case for the change to the > default sort order. I very much prefer that *all* changes to routines in C4 > and Koha be accompanied by test cases. > > Note that in order for this patch to apply cleanly, the patch for bug 10577 > must be applied first. I applied 10577, then 10535, ran the test, and all looked good. Since 10577 has failed QA, what's the proper process now? Wait until 10577 passes QA or is pushed?
First patch pushed to 3.10.x, will be in 3.10.10
First patch pushed to 3.8.x, will be in 3.8.17
Created attachment 20563 [details] [review] Bug 10535: (follow-up) add test case This adds a test case for the new default sort order for GetBudgets(). Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Created attachment 20579 [details] [review] Bug 10535: (follow-up) add test case This adds a test case for the new default sort order for GetBudgets(). Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Follow-up pushed to master.
Follow-up pushed to 3.12.x, will be in 3.12.8. Thanks Galen!