In connection to bug 4246 commit 591bae324d77d285b27dfa6e10dc7001671f53cc added phone to the message_transport_types table in updatedatabase.pl This should be done also for new installs via the .sql files of the web installer. I am adding it only to English now, basing this change upon the work in reports 10509 and 10520. (I discovered this tiny omission there too.)
Created attachment 19548 [details] [review] Bug 10572: Add phone to message_transport_types table for new installs In connection to bug 4246 commit 591bae324d77d285b27dfa6e10dc7001671f53cc added phone to the message_transport_types table in updatedatabase.pl This should be done also for new installs via the .sql files of the web installer. I am adding it only to English now, basing this change upon the work in reports 10509 and 10520. (I discovered this tiny omission there too.) Test plan: Apply patches 10509/10520. Run new install or run this particular sql file from command line. Note: If you only run this particular file, you do not need patch 10509.
Created attachment 20075 [details] [review] Bug 10572: Add phone to message_transport_types table for new installs In connection to bug 4246 commit 591bae324d77d285b27dfa6e10dc7001671f53cc added phone to the message_transport_types table in updatedatabase.pl This should be done also for new installs via the .sql files of the web installer. I am adding it only to English now, basing this change upon the work in reports 10509 and 10520. (I discovered this tiny omission there too.) Test plan: Apply patches 10509/10520. Run new install or run this particular sql file from command line. Note: If you only run this particular file, you do not need patch 10509. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Hi Kyle, this could go in as a bugfix to earlier versions as well, but the new web installer translations probably can't. Could you provide a follow-up please?
Also, I think to fix this properly we shoudl include a database update. It looks like 4246 has been released with 3.10, so there is a good chance of people installing 3.10 or 3.12 will have missed the database update and will have the problem.
Created attachment 20142 [details] [review] Bug 10572: Followup: dbrev for phone message_transport_type Test plan: Run the updatestructure step of web installer. Check if you have a phone message_transport_type. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Back to Signed off.
Kyle, could you address comment 3 please?
(In reply to Katrin Fischer from comment #7) > Kyle, could you address comment 3 please? Is not it fixed with the second patch?
Created attachment 21051 [details] [review] Bug 10572 - Add phone to message_transport_types table for new installs- QA Followup
Created attachment 21052 [details] [review] Bug 10572: Add phone to message_transport_types table for new installs In connection to bug 4246 commit 591bae324d77d285b27dfa6e10dc7001671f53cc added phone to the message_transport_types table in updatedatabase.pl This should be done also for new installs via the .sql files of the web installer. I am adding it only to English now, basing this change upon the work in reports 10509 and 10520. (I discovered this tiny omission there too.) Test plan: Apply patches 10509/10520. Run new install or run this particular sql file from command line. Note: If you only run this particular file, you do not need patch 10509. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 21053 [details] [review] Bug 10572: Followup: dbrev for phone message_transport_type Test plan: Run the updatestructure step of web installer. Check if you have a phone message_transport_type. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 21054 [details] [review] Bug 10572 - Add phone to message_transport_types table for new installs- QA Followup Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed to master. Thanks, Marcel!