Bug 10575 - UT: GetOrdersByBiblionumber.t needs a database transaction
Summary: UT: GetOrdersByBiblionumber.t needs a database transaction
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal (vote)
Assignee: kenza
QA Contact:
URL:
Keywords:
Depends on: 10270
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-11 14:03 UTC by kenza
Modified: 2014-12-07 20:03 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
GetOrdersByBiblionumber.t needs a database transaction (1.97 KB, patch)
2013-07-11 14:43 UTC, kenza
Details | Diff | Splinter Review
Bug 10575 : GetOrdersByBiblionumber.t needs a database transaction (1.99 KB, patch)
2013-07-14 07:09 UTC, Chris Cormack
Details | Diff | Splinter Review
[PASSED QA] Bug 10575 : GetOrdersByBiblionumber.t needs a database transaction (2.07 KB, patch)
2013-07-14 07:17 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description kenza 2013-07-11 14:03:49 UTC

    
Comment 1 kenza 2013-07-11 14:43:56 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2013-07-14 07:09:10 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2013-07-14 07:17:41 UTC
Created attachment 19618 [details] [review]
[PASSED QA] Bug 10575 : GetOrdersByBiblionumber.t needs a database transaction

Before this patch, the queries in GetOrdersByBiblionumber.t were commited in the database and have to be removed at the end.
This patch wraps tests in a database transaction.

Test Plan :
prove t/db_dependent/Acquisition/GetOrdersByBiblionumber.t
t/db_dependent/Acquisition/GetOrdersByBiblionumber.t .. ok
All tests successful.
Files=1, Tests=3,  0 wallclock secs ( 0.02 usr  0.01 sys +  0.37 cusr  0.05 csys =  0.45 CPU)
Result: PASS

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Tests pass.
Comment 4 Galen Charlton 2013-07-15 16:22:59 UTC
Pushed to master.  Thanks, Kenza, and congratulations on having your first patch accepted into Koha!
Comment 5 Tomás Cohen Arazi 2013-07-25 17:15:23 UTC
This patch has been pushed to 3.12.x, will be in 3.12.3.

Thanks Kenza!