Bug 10617 - Init script cleanup
Summary: Init script cleanup
Alias: None
Product: Koha
Classification: Unclassified
Component: Packaging (show other bugs)
Version: master
Hardware: All All
: P5 - low trivial (vote)
Assignee: Tomás Cohen Arazi
QA Contact: Testopia
Depends on:
Blocks: 10624
  Show dependency treegraph
Reported: 2013-07-19 20:53 UTC by Tomás Cohen Arazi
Modified: 2014-05-26 21:04 UTC (History)
2 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Trivial patch
Who signed the patch off:
Text to go in the release notes:
Version(s) released in:

Bug 10617 - koha-common tnit script cleanup (2.91 KB, patch)
2013-07-19 20:59 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 10617 - koha-common init script cleanup (3.24 KB, patch)
2013-07-22 15:50 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 10617 - koha-common init script cleanup (3.29 KB, patch)
2013-09-19 04:25 UTC, Robin Sheat
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi 2013-07-19 20:53:43 UTC
The debian/koha-common.init file needs some cleanup.
Comment 1 Tomás Cohen Arazi 2013-07-19 20:59:41 UTC Comment hidden (obsolete)
Comment 2 Tomás Cohen Arazi 2013-07-22 15:50:09 UTC Comment hidden (obsolete)
Comment 3 Robin Sheat 2013-09-19 04:23:46 UTC
I don't think we need to have PERL5LIB defined in the config for this. It shouldn't break anything though.
Comment 4 Robin Sheat 2013-09-19 04:25:20 UTC
Created attachment 21218 [details] [review]
Bug 10617 - koha-common init script cleanup

Removed unused stuff, added a new config file /etc/default/koha-common
to control the init script behaviour. Currently is only a stub. The config
file could be put on /etc/sysconfig on RedHat and friends. The init script
should work them too. Added a TODO comment regarding the 'status' switch.

To test:
- Apply the patch on master, build your own packages and install.
- The init script should continue to work as expected.
(it can be tested replacing the /etc/init.d/koha-common file with
debian/koha-common.init on a packages install).
- The absence of the /etc/default/koha-common file should not prevent
the init script from working.


Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: Robin Sheat <robin@catalyst.net.nz>
Comment 5 Galen Charlton 2013-09-21 17:41:38 UTC
Pushed to master.  Thanks, Tomás!
Comment 6 Tomás Cohen Arazi 2013-11-13 16:20:43 UTC
This patch has been pushed to 3.12.x, will be in 3.12.7.