Bug 10684 - Koha search dies on undecodable records
Summary: Koha search dies on undecodable records
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Searching (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Kyle M Hall
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-05 13:24 UTC by Kyle M Hall
Modified: 2015-06-04 23:23 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 10684 - Koha search dies on undecodable records (1.04 KB, patch)
2013-08-05 13:29 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 10684 - Koha search dies on undecodable records (1.08 KB, patch)
2013-08-08 23:01 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 10684 - Koha search dies on undecodable records (1.15 KB, patch)
2013-08-26 15:40 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 10684 - Followup Koha search dies on undecodable records (1.10 KB, patch)
2013-08-26 15:40 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 10684 - Followup Koha search dies on undecodable records (1.15 KB, patch)
2013-08-26 17:05 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2013-08-05 13:24:55 UTC
When a record fails to decode during a search, Koha dies with an error. Koha should ignore bad records and continue on ( and log the error ).
Comment 1 Kyle M Hall 2013-08-05 13:29:04 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2013-08-05 14:13:34 UTC
Please add a test plan. How can one load/modify a record so as to reproduce the error and confirm the fix?
Comment 3 Kyle M Hall 2013-08-05 17:19:57 UTC
That is something I've yet to figure out. This is a fix I wrote for a production server where the database marc and marcxml are valid, but the marc sent by zebra is bad. I have no idea how to intentionally cause this issue.

However, one can prove the patch is not deleterious simply by applying the patch and searching for records within Koha.
Comment 4 Chris Cormack 2013-08-08 23:01:49 UTC Comment hidden (obsolete)
Comment 5 Jonathan Druart 2013-08-26 15:39:05 UTC
QA comment:
No way to reproduce but catching possible error on this method is not a bad idea.
Marked as Passed QA.
Comment 6 Jonathan Druart 2013-08-26 15:40:06 UTC
Created attachment 20632 [details] [review]
Bug 10684 - Koha search dies on undecodable records

When a record fails to decode during a search, Koha dies with an error.
Koha should ignore bad records and continue on ( and log the error ).

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 7 Jonathan Druart 2013-08-26 15:40:10 UTC Comment hidden (obsolete)
Comment 8 Kyle M Hall 2013-08-26 17:05:41 UTC
Created attachment 20635 [details] [review]
Bug 10684 - Followup Koha search dies on undecodable records

Prevent future error.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 9 Galen Charlton 2013-11-14 18:14:06 UTC
Pushed to master and 3.14.x, along with a regression test.  Thanks, Kyle!
Comment 10 Tomás Cohen Arazi 2013-11-21 13:18:56 UTC
This patch has been pushed to 3.12.x, will be in 3.12.7.

Thanks Kyle!