Bug 10917 - Librarian cannot update hold pickup location without modify_holds_priority
Summary: Librarian cannot update hold pickup location without modify_holds_priority
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Kyle M Hall
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-19 16:17 UTC by Kyle M Hall
Modified: 2014-12-07 20:02 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 10917 - Librarian cannot update hold pickup location without modify_holds_priority (3.30 KB, patch)
2013-09-19 16:21 UTC, Kyle M Hall
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 10917 - Librarian cannot update hold pickup location without modify_holds_priority (3.40 KB, patch)
2013-09-25 17:46 UTC, Owen Leonard
Details | Diff | Splinter Review
[PASSED QA] Bug 10917 - Librarian cannot update hold pickup location without modify_holds_priority (3.79 KB, patch)
2013-10-05 20:18 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2013-09-19 16:17:43 UTC
A librarian cannot modify a hold's pickup location unless he or she has the permission modify_holds_priority. This appears to be a bug and not by design. The reason the update fails is due to the priority not being passed to ModReserve. The priority is not displayed when a librarian does not have the modify_holds_priority permission.
Comment 1 Kyle M Hall 2013-09-19 16:21:46 UTC Comment hidden (obsolete)
Comment 2 Christopher Brannon 2013-09-19 18:21:40 UTC
I've tested this patch on our server, and it works as expected.
Comment 3 I'm just a bot 2013-09-24 05:44:22 UTC
Patch applied cleanly, go forth and signoff
Comment 4 Owen Leonard 2013-09-25 17:46:40 UTC Comment hidden (obsolete)
Comment 5 Katrin Fischer 2013-10-05 20:18:41 UTC
Created attachment 21827 [details] [review]
[PASSED QA] Bug 10917 - Librarian cannot update hold pickup location without modify_holds_priority

A librarian cannot modify a hold's pickup location unless he or she has
the permission modify_holds_priority. This appears to be a bug and not
by design. The reason the update fails is due to the priority not being
passed to ModReserve. The priority is not displayed when a librarian
does not have the modify_holds_priority permission.

Test Plan:
1) Remove the modify_holds_priority from your logged in user
   * User cannot be a superlibrarian
2) Attempt to change the pickup location for a hold
3) Note the change fails
4) Apply this patch
5) Repeat step 2
6) Note the change succeeds

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Template change only.
Passes all tests and QA script.

Tested:
- Confirmed that changing the pickup location is not
  possible in master without the modify_holds_priority
  permission
- Confirmed that the patch fixes the problem - pickup
  location can now be changed with and without the
  permission
- Pickup location can still not be changed, when
  IndependentBranches is activated
Comment 6 Galen Charlton 2013-10-08 14:31:32 UTC
Pushed to master.  Thanks, Kyle!