Bug 11060 - Bootstrap theme: Incorrect rendering for right to left languages
Summary: Bootstrap theme: Incorrect rendering for right to left languages
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low major (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 10309
Blocks:
  Show dependency treegraph
 
Reported: 2013-10-16 11:28 UTC by Bernardo Gonzalez Kriegel
Modified: 2014-12-07 20:02 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
opac-bootstrap-l2r (19.74 KB, image/png)
2013-10-16 11:28 UTC, Bernardo Gonzalez Kriegel
Details
opac-ccsr-l2r (27.87 KB, image/png)
2013-10-16 11:28 UTC, Bernardo Gonzalez Kriegel
Details
Bug 11060 - Bootstrap theme: Incorrect rendering for right to left languages (318.14 KB, patch)
2013-10-21 17:12 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 11060 - Bootstrap theme: Incorrect rendering for right to left languages (318.48 KB, patch)
2013-10-21 17:32 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
Bug 11060 - Bootstrap theme: Incorrect rendering for right to left languages (318.63 KB, patch)
2013-10-21 17:43 UTC, Chris Cormack
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Bernardo Gonzalez Kriegel 2013-10-16 11:28:25 UTC
Created attachment 22014 [details]
opac-bootstrap-l2r

New bootstrap theme do not render correctly for R2L languages like Arabic.

Good: Search bar

Not good: Advance search, auth search etc, are rendered correctly but there is too much space from the right

Bad: Top (black) bar, Main result box, language chooser (hidden below as noted on Bug 11057)

Attached bootstrap screen capture and ccsr for comaparison.
Comment 1 Bernardo Gonzalez Kriegel 2013-10-16 11:28:58 UTC
Created attachment 22015 [details]
opac-ccsr-l2r
Comment 2 Owen Leonard 2013-10-21 17:12:35 UTC Comment hidden (obsolete)
Comment 3 Bernardo Gonzalez Kriegel 2013-10-21 17:32:57 UTC Comment hidden (obsolete)
Comment 4 Chris Cormack 2013-10-21 17:43:21 UTC
Created attachment 22170 [details] [review]
Bug 11060 - Bootstrap theme: Incorrect rendering for right to left languages

The right-to-left CSS copied over from the prog theme does is not
relevant to the redesigned templates. This patch updates the OPAC's
right-to-left CSS and adds a couple of other right-to-left CSS files to
override the default Bootstrap and jQueryUI CSS.

To my eye this looks correct, but I don't speak Arabic.

To test you must have a set of right-to-left templates, like
ar-Arab, installed for the Bootstrap theme. At this time it is necessary
to download the po file to your misc/translator/po directory. Again
using ar-Arab as an example:

http://translate.koha-community.org/ar/314/ar-Arab-opac-bootstrap.po

Install the translation.

Open the OPAC, switch to that right-to-left language, and reload to
refresh the changed CSS. Confirm that it looks like right-to-left is
working.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>

As far as I can tell it looks very well.
No koha-qa errors

1) Downloaded arabic bootstrap PO
2) Installed ar-Arab language, enabled on OPAC
3) Tested as anonymous user and logged in one, all pages look
well: cart, advanced search, user tabs.

I sent an email to Karam Qubsi asking his opinion.
But for me it's ok

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>

I was testing this at the same time as Bernardo, so I will Pass QA on
it, instead of signing it off
Comment 5 Galen Charlton 2013-10-21 18:22:25 UTC
Pushed to master.  Thanks, Owen!