Bug 9209 removes the only occurrence to Koha::Calendar::_mock_init The routine can be removed.
Created attachment 22018 [details] [review] Bug 11061: Koha::Calendar::_mock_init is unused Bug 9209 removes the only occurrence to Koha::Calendar::_mock_init The routine can be removed. Test plan: prove t/Calendar.t
Created attachment 22434 [details] [review] Bug 11061: Koha::Calendar::_mock_init is unused Bug 9209 removes the only occurrence to Koha::Calendar::_mock_init The routine can be removed. Test plan: prove t/Calendar.t Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> I left that routine because I planned to do a follow-up for that so the Calendar patch series was pushed soon. Nice catch Jonathan, works as expected.
Created attachment 23101 [details] [review] Bug 11061: Koha::Calendar::_mock_init is unused Bug 9209 removes the only occurrence to Koha::Calendar::_mock_init The routine can be removed. Test plan: prove t/Calendar.t Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> I left that routine because I planned to do a follow-up for that so the Calendar patch series was pushed soon. Nice catch Jonathan, works as expected. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Passes koha-qa.pl, t and xt
Pushed to master. Thanks, Jonathan!
This patch has been pushed to 3.14.x, will be in 3.14.1
This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Jonathan!