When OPAC most populars uses collection code, it does not work. There are never results.
Created attachment 22387 [details] [review] Bug 11139 - opac-topissues does not work with CCODE See commit message
testing 1 commit(s) (applied to 5fa6168 'Bug 11204: make pendingreserves use d') [1;32mOK[0m opac/opac-topissues.pl
I can't reproduce this problem in master. I get results when either item type or collection code.
(In reply to Owen Leonard from comment #3) > I can't reproduce this problem in master. I get results when either item > type or collection code. Is your authorised values catégory for collection codes : ccode or CCODE ?
(In reply to Fridolyn SOMERS from comment #4) > Is your authorised values catégory for collection codes : ccode or CCODE ? CCODE.
Created attachment 24103 [details] no option to limit on ccode I don't even see an option for collection code in the opac top issue.
> I don't even see an option for collection code in the opac top issue. You have to have the AdvancedSearchTypes preference set to 'ccode'
Created attachment 25956 [details] [review] Bug 11139 - opac-topissues does not work with CCODE When OPAC most populars uses collection code, it does not work. There are never results. This patch corrects two points: - SQL query uses 'ccode' as collection code authorised values category, it is CCODE uppercase - The constraint category='CCODE' must be inside join detween items and authorised_values, in this case items.ccode may be NULL Test plan : On a catalogue where items.ccode is defined and uses CCODE authorised values : - Set syspref AdvancedSearchTypes = ccode - Go to opac-topissues.pl - If no results, select "No limit" in "of the last:" and submit => You get results - Select in results a biblio and remove items.ccode from all its items - Refresh opac-topissues.pl (check "All collections" is selected in "Limit to:") => The biblio is still in results Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
I think this patch is incomplete - AdvancedSearchTypes is no longer a switch, but can have multiple values: loc - NOT OK, the itemtype pull down still shows, but it's empty ccode - OK, collections show itemtypes - OK, itemtypes show ccode|itemtpyes - NOT OK, pull down empty itemtypes|loc - NOT OK, pull down empty
One of your client still have this problem with 3.18.08
Bug 14788 fixes the ccode problem, but not the "multiple values" problem. So here is a patch that try to fix it (depends on 14788):
Created attachment 43008 [details] [review] Bug 11139: Add support for multiple values in AdvancedSearchTypes AdvancedSearchTypes syspref can be multivalued, opac-topissues.pl have to support that. AdvancedSearchTypes can have one or more of the following values: 'itemtypes', 'ccode', 'loc'. But this patch adds support only for itemtypes and ccode. AdvancedSearchTypes can still contain 'loc' but it will change nothing to the behaviour of opac-topissues.pl. This patch also removes duplicate code in template (the "Refine your search" form was written in two different places) This introduces a small behaviour change: when there is no results, instead of having the form in the center of the page, it remains in the left sidebar and we have a "No results" message in the main area. Depends on bug 14788
Nice job Julian
Hi Julian and Fridolin, It might be a good idea to have a separate syspref for the behavior of the most popular list instead of the double use of 'AdvancedSearchTypes' It would make things much more clearer. What do you think? Marc
(In reply to Marc Véron from comment #14) > Hi Julian and Fridolin, > > It might be a good idea to have a separate syspref for the behavior of the > most popular list instead of the double use of 'AdvancedSearchTypes' > > It would make things much more clearer. > > What do you think? > > Marc I agree
Created attachment 43416 [details] [review] Bug 11139: Add support for multiple values in AdvancedSearchTypes AdvancedSearchTypes syspref can be multivalued, opac-topissues.pl have to support that. AdvancedSearchTypes can have one or more of the following values: 'itemtypes', 'ccode', 'loc'. But this patch adds support only for itemtypes and ccode. AdvancedSearchTypes can still contain 'loc' but it will change nothing to the behaviour of opac-topissues.pl. This patch also removes duplicate code in template (the "Refine your search" form was written in two different places) This introduces a small behaviour change: when there is no results, instead of having the form in the center of the page, it remains in the left sidebar and we have a "No results" message in the main area. Depends on bug 14788 Tested on top of 14788. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch>
*** Bug 12136 has been marked as a duplicate of this bug. ***
Created attachment 43732 [details] [review] [PASSED QA] Bug 11139: Add support for multiple values in AdvancedSearchTypes AdvancedSearchTypes syspref can be multivalued, opac-topissues.pl have to support that. AdvancedSearchTypes can have one or more of the following values: 'itemtypes', 'ccode', 'loc'. But this patch adds support only for itemtypes and ccode. AdvancedSearchTypes can still contain 'loc' but it will change nothing to the behaviour of opac-topissues.pl. This patch also removes duplicate code in template (the "Refine your search" form was written in two different places) This introduces a small behaviour change: when there is no results, instead of having the form in the center of the page, it remains in the left sidebar and we have a "No results" message in the main area. Depends on bug 14788 Tested on top of 14788. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Patch pushed to master. Thanks Maurice!