The --munge-config option of rebuild_zebra.pl attempts to create a valid Zebra configuration. While there was a period in the 3.0 days where this might have been useful, nowadays this option would either not work, or if it does work, be actively dangerous.
Created attachment 22944 [details] [review] Bug 11252: remove deprecated -munge-config switch from rebuild_zebra.pl The -munge-config switch has been deprecated for years, and trying to use it would either not work at all or, if it did "work", almost certainly damage one's Zebra configuration for Koha. This patch removes this switch. To test: [1] Run rebuild_zebra.pl and verify that no mention is made of -munge-config. [2] Run rebuild_zebra.pl to index records in one's test database and verify that there are no regressions. Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Created attachment 23766 [details] [review] Bug 11252: remove deprecated -munge-config switch from rebuild_zebra.pl The -munge-config switch has been deprecated for years, and trying to use it would either not work at all or, if it did "work", almost certainly damage one's Zebra configuration for Koha. This patch removes this switch. To test: [1] Run rebuild_zebra.pl and verify that no mention is made of -munge-config. [2] Run rebuild_zebra.pl to index records in one's test database and verify that there are no regressions. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Removing a really dangerous option
Created attachment 23820 [details] [review] [PASSED QA] Bug 11252: remove deprecated -munge-config switch from rebuild_zebra.pl The -munge-config switch has been deprecated for years, and trying to use it would either not work at all or, if it did "work", almost certainly damage one's Zebra configuration for Koha. This patch removes this switch. To test: [1] Run rebuild_zebra.pl and verify that no mention is made of -munge-config. [2] Run rebuild_zebra.pl to index records in one's test database and verify that there are no regressions. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Removing a really dangerous option Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Ran rebuild_zebra.pl with various options and confirmed that data was reindexed successfully. No regressions found.
Pushed to master.
Patch pushed to 3.14.x, will be in 3.14.2.