In Item view moredetail.pl, one is given the choice of selecting authorized values for Lost and Damaged statuses through a drop down. However, Withdrawn is a toggle, even though Withdrawn can be assigned various values in the same way as Lost and Damaged. I am proposing that the Withdrawn status have the same selection menu and "set status" formulation as Lost and Damaged. Statuses ( Lost ) Current location: Checkout status: Current renewals: Lost status: Damaged status: Withdrawn?:No
Still valid.
Still valid. Requested by library staff
Created attachment 45471 [details] [review] Bug 11280 - Change Withdrawn toggle to drop down selection of authorized values 'Withdrawn' is an authorised value just like 'Lost' and 'Damaged,' so the item detail screen should offer the same means of selecting one of multiple values. This patch re-uses the same template markup and code 'Lost' and 'Damage' use to make it possible to select a specific withdrawn value. To test you should have multiple values entered for the authorised value category 'WITHDRAWN'. 1. Apply the patch and locate any record in the catalog. 2. From the detail screen, click the barcode in the items table to go to the item detail page. 3. Confirm that there is a dropdown list of choices for 'Withdrawn status.' 4. Try both setting and unsetting various withdrawn statuses. 5. Confirm that setting Lost or Damaged statuses.
Created attachment 46014 [details] [review] Bug 11280 - Change Withdrawn toggle to drop down selection of authorized values 'Withdrawn' is an authorised value just like 'Lost' and 'Damaged,' so the item detail screen should offer the same means of selecting one of multiple values. This patch re-uses the same template markup and code 'Lost' and 'Damage' use to make it possible to select a specific withdrawn value. To test you should have multiple values entered for the authorised value category 'WITHDRAWN'. 1. Apply the patch and locate any record in the catalog. 2. From the detail screen, click the barcode in the items table to go to the item detail page. 3. Confirm that there is a dropdown list of choices for 'Withdrawn status.' 4. Try both setting and unsetting various withdrawn statuses. 5. Confirm that setting Lost or Damaged statuses. Signed-off-by: Aleisha <aleishaamohia@hotmail.com>
The patch works as expected, but I am wondering if you should not take into account the values which could not exist in the AV. This could cause data lost.
Hi Jonathan, can you give an example? Not sure I understand.
Created attachment 46854 [details] [review] Bug 11280 - Change Withdrawn toggle to drop down selection of authorized values 'Withdrawn' is an authorised value just like 'Lost' and 'Damaged,' so the item detail screen should offer the same means of selecting one of multiple values. This patch re-uses the same template markup and code 'Lost' and 'Damage' use to make it possible to select a specific withdrawn value. To test you should have multiple values entered for the authorised value category 'WITHDRAWN'. 1. Apply the patch and locate any record in the catalog. 2. From the detail screen, click the barcode in the items table to go to the item detail page. 3. Confirm that there is a dropdown list of choices for 'Withdrawn status.' 4. Try both setting and unsetting various withdrawn statuses. 5. Confirm that setting Lost or Damaged statuses. Signed-off-by: Aleisha <aleishaamohia@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(In reply to Katrin Fischer from comment #6) > Hi Jonathan, can you give an example? Not sure I understand. Sorry, forget that, it did not make sense.
Pushed to Master - Should be in the May 2016 release. Thanks!