Bug 11291 - Change the behavior of any index in DOM indexing
Summary: Change the behavior of any index in DOM indexing
Status: Failed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Searching (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: mathieu saby
QA Contact: Testopia
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-22 23:58 UTC by mathieu saby
Modified: 2016-10-04 16:36 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
[PATCH] Bug 11291 : Make the any index more precise for DOM indexing (420.52 KB, patch)
2013-11-23 00:18 UTC, mathieu saby
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description mathieu saby 2013-11-22 23:58:03 UTC
The behavior of "any" index should be the same in DOM and GRS-1 indexing modes.
To do so, a change must be made to the xslt stylesheet used for transforming *-koha* files to *-zebra* files.
Comment 1 mathieu saby 2013-11-23 00:18:38 UTC
Created attachment 23114 [details] [review]
[PATCH] Bug 11291 : Make the any index more precise for DOM indexing


Any index is generated by a template in koha-indexdefs-to-zebra.xsl.
This template is applied to all fields of the record. This should be made more precise.
This patch removes this template, and adds "Any:w Any:p" to the $indexes variable generated in 4 templates of of koha-indexdefs-to-zebra.xsl
This patch also provides regenerated *-zebra-indexdefs.xsl files of biblio and auth of each marcflavor.

To test:
1. apply the patch
2. copy the modified authority-zebra-indexdefs.xsl and biblio-zebra-indexdefs.xsl into the configuration directory of your Zebra
3. rebuild Zebra for authorities (rebuild_zebra with -a -r -v )
4. rebuild Zebra for authorities (rebuild_zebra with -b -r -v )
5. make some searchs in staff interface and OPAC, with simple index and specific indexes (title, author...)
6. check no index is broken
7. put some very special value (like "qwerty000") in a record, in a field NOT indexed in any specific Zebra index (it depends of your marcflavor...)
8. search this special value in simple search => you should have 0 result

repeat these steps for MARC21 and UNIMARC
Comment 2 mathieu saby 2013-11-23 12:26:08 UTC
Maybe that's not a so good idea ;-)
Message sent to koha-devel.

Mathieu
Comment 3 Martin Renvoize 2014-02-26 17:41:17 UTC
I added a followup to bug 8962 to implement the anywhere index and cut down the any index for dom as per that bug. I think that mostly removes the need for this patch.
Comment 4 David Cook 2014-06-19 05:12:12 UTC
If I recall correctly, we're supposed to make changes to the XML then produce the requisite XSLT based on that using xsltproc.

This patch just uses the XSLT. Please provide a new patch that updates the XML and post the XSLT that is created from that XML.
Comment 5 mathieu saby 2014-06-19 11:25:26 UTC
Hello Martin and David
as I am no longer involved in Koha development, except for a few bugs I am still watching, I won't work anymore on this bug, or bug 8962. But I hope you will find a solution for improving Koha's indexing, which is not perfect ;-)

Mathieu
Comment 6 Marc Véron 2016-10-04 16:36:11 UTC
Still valid?