Bug 11310 - Update XSLT stylesheets in bootstrap theme
Summary: Update XSLT stylesheets in bootstrap theme
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
: 11758 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-11-27 07:28 UTC by Katrin Fischer
Modified: 2015-06-04 23:30 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Medium patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11310: update the XSLT for the Bootstrap theme (75.96 KB, patch)
2014-01-06 17:00 UTC, Galen Charlton
Details | Diff | Splinter Review
Bug 11310: update the XSLT for the Bootstrap theme (43.24 KB, patch)
2014-02-16 08:52 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 11310: update the XSLT for the Bootstrap theme (43.38 KB, patch)
2014-02-18 15:02 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2013-11-27 07:28:27 UTC
I noticed today that the "Continues:" label is missing a space after the label on the bootstrap theme. This has been fixed a while ago on the prog theme - I think easiest would be to copy the XSLT files, so both filesets are current.
Comment 1 Galen Charlton 2014-01-06 17:00:16 UTC Comment hidden (obsolete)
Comment 2 Galen Charlton 2014-01-06 17:03:36 UTC
I think it would be reasonable to consider making the OPAC XSLT stylesheets not be specific to a particular theme, but instead be shared by all of them.  Even if that's the final decision, I think it would be a good idea for this patch to be reviewed and pushed, as having the XSLT be identical in the two major themes prior to moving it will make it easier to validate the consolidation.
Comment 3 David Cook 2014-01-07 02:12:08 UTC
(In reply to Galen Charlton from comment #2)
> I think it would be reasonable to consider making the OPAC XSLT stylesheets
> not be specific to a particular theme, but instead be shared by all of them.
> Even if that's the final decision, I think it would be a good idea for this
> patch to be reviewed and pushed, as having the XSLT be identical in the two
> major themes prior to moving it will make it easier to validate the
> consolidation.

+1 

Personally, I don't see a need to duplicate XSLTs across the different themes. I think it just adds more chance of error.

In theory, someone might want to tie an XSLT to a theme, so that different themes show different data, but I don't see the purpose of that, since we can already specify different XSLTs in the system preferences.

Reduce the boilerplate, me thinks.
Comment 4 Chris Cormack 2014-02-16 08:52:42 UTC Comment hidden (obsolete)
Comment 5 Katrin Fischer 2014-02-16 20:11:12 UTC
*** Bug 11758 has been marked as a duplicate of this bug. ***
Comment 6 Jonathan Druart 2014-02-18 15:02:40 UTC
Created attachment 25376 [details] [review]
Bug 11310: update the XSLT for the Bootstrap theme

When the Bootstrap theme was started, the XSLT directory
was copied over from the prog theme.  However, it was not
kept up to date with respect to changes to prog's XSLT.

This patch rectifies the problem by copying over the
current state of prog/en/xslt to bootstrap/en/xslt.  As
a consequence, the following bugs or enhancements should
now be reflected in the Bootstrap theme:

* 6886
* 10905
* 10465
* 10564
* 10793
* 10218
* 6594
* 9820
* 10745
* 6553
* 10218
* 10284

To test:

[1] Apply the patch and ensure that OPACXSLTDetailsDisplay
    and OPACXSLTResultsDisplay are set to 'default' and that
    OPAC theme is set to 'bootstrap'.
[2] Ensure that OPAC results and bib details look OK.
[3] To be really thorough, run through the test plans for the
    other bugs referenced by this patch.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
diff -w bootstrap/en/xslt/XXX prog/en/xslt/XXX returns no difference.
Comment 7 Galen Charlton 2014-02-18 20:37:03 UTC
Pushed to master.
Comment 8 Dan Scott 2014-02-19 13:57:38 UTC
As this bug addresses regressions from the prior default theme to the new default theme in 3.14, will the patch also be backported to 3.14?
Comment 9 Katrin Fischer 2014-02-19 14:00:34 UTC
Hi Dan, as this is marked  as bug (vs. enhancement or new feature) it is likely to be backported to earlier versions, but it's up to the RMaint to make the decision.
Comment 10 Fridolin Somers 2014-06-03 12:34:17 UTC
Pushed to 3.14.x, will be in 3.14.08
Comment 11 Fridolin Somers 2014-06-03 12:35:12 UTC
There was no pb backporting this bug.
I've just waited a bit because of previous string freeze.