Bug 11330 - Inconsistent field/subfield descriptions on MARC21 bibliographic frameworks
Summary: Inconsistent field/subfield descriptions on MARC21 bibliographic frameworks
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: MARC Bibliographic data support (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Bernardo Gonzalez Kriegel
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-03 01:55 UTC by Bernardo Gonzalez Kriegel
Modified: 2019-11-28 11:06 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
check-diff.sh (1.81 KB, application/x-shellscript)
2013-12-03 18:24 UTC, Bernardo Gonzalez Kriegel
Details
Bug 11330 - Inconsistent field/subfield descriptions on MARC21 bibliographic frameworks (957.99 KB, patch)
2013-12-03 18:31 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
Bug 11330 - Inconsistent field/subfield descriptions on MARC21 bibliographic frameworks (929.71 KB, patch)
2013-12-03 23:23 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
[SIGNED OFF] Bug 11330 - Inconsistent field/subfield descriptions on MARC21 bibliographic frameworks (929.03 KB, patch)
2013-12-05 18:47 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 11330: Follow-up - Inconsistent field/subfield descriptions on MARC21 bibiographic frameworks (1.97 KB, patch)
2013-12-05 18:47 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 11330 - Inconsistent field/subfield descriptions on MARC21 bibliographic frameworks (928.00 KB, patch)
2014-01-17 12:25 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 11330: Follow-up - Inconsistent field/subfield descriptions on MARC21 bibiographic frameworks (2.01 KB, patch)
2014-01-17 12:25 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Bernardo Gonzalez Kriegel 2013-12-03 01:55:50 UTC
There are many inconsistencies on field/subfield descriptions on MARC21 bibliographic frameworks.

That fact makes very hard to translate frameworks accurately using an automated procedure
Comment 1 Katrin Fischer 2013-12-03 11:26:21 UTC
I think for consistency it also makes sense to have the descriptions the same on each framework. But also it will be really nice to have the marc frameworks nicely translatable with po files.
Comment 2 Bernardo Gonzalez Kriegel 2013-12-03 18:24:47 UTC
Created attachment 23277 [details]
check-diff.sh

script to check frameworks
Comment 3 Bernardo Gonzalez Kriegel 2013-12-03 18:31:23 UTC Comment hidden (obsolete)
Comment 4 Bernardo Gonzalez Kriegel 2013-12-03 21:56:46 UTC
Found some changes that need to be done.
Switch to In Discussion
Comment 5 Bernardo Gonzalez Kriegel 2013-12-03 23:23:56 UTC Comment hidden (obsolete)
Comment 6 Bernardo Gonzalez Kriegel 2013-12-03 23:51:58 UTC
Now it's ready
Comment 7 Katrin Fischer 2013-12-05 18:47:18 UTC Comment hidden (obsolete)
Comment 8 Katrin Fischer 2013-12-05 18:47:37 UTC Comment hidden (obsolete)
Comment 9 Kyle M Hall 2014-01-17 12:25:48 UTC
Created attachment 24488 [details] [review]
Bug 11330 - Inconsistent field/subfield descriptions on MARC21 bibliographic frameworks

This patch tries to make MARC21 bibliographic frameworks
internally consistent. It modifies field/subfield descriptions
of simple_bib and fastadd frameworks to match corresponding
ones of default framework.

To test:
1) Download and edit the attached script, check-diff.sh
Put on it user, pass and database name of your dev install
Copy the script on your git home

2) Run the script (bash check-diff.sh).
WARNING: the script removes bibliographic frameworks, and load
default, simple_bib and fastadd ones.
It will show on screen, and write on file differences.txt,
any difference on field/subfield description (liblibrarian)
between any framework and default

On master it will show a lot of lines

3) Apply the patch

4) Run the script again. Frameworks files must load without problem.
There will be no differences

NOTE: There are many "space" changes. The reason
to that is to format files to ease the translation process.
Not related with this bug, but necessary.
Also a few changes on default framework.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
I ran some tests and found one more case where the
liblibrarian and libopac columns had slightly different
descriptions, adding a follow-up for that.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 10 Kyle M Hall 2014-01-17 12:25:58 UTC
Created attachment 24489 [details] [review]
Bug 11330: Follow-up - Inconsistent field/subfield descriptions on MARC21 bibiographic frameworks

Fixes one missing for 951 field description in the Default framework.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 11 Galen Charlton 2014-01-17 15:50:42 UTC
Pushed to master.  Thanks, Bernardo!