Bug 11386 - Mandatory fields in subscription add form should use standard formatting
Summary: Mandatory fields in subscription add form should use standard formatting
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Serials (show other bugs)
Version: 3.14
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Julian Maurice
QA Contact: Testopia
URL:
Keywords:
Depends on: 7688
Blocks:
  Show dependency treegraph
 
Reported: 2013-12-11 20:25 UTC by Katrin Fischer
Modified: 2014-12-07 20:03 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11386: Use jQuery.validate plugin for subscription add/edit form (9.21 KB, patch)
2013-12-19 11:08 UTC, Julian Maurice
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 11386 - Mandatory fields in subscription add form should use standard formatting (9.38 KB, patch)
2014-03-12 19:19 UTC, Owen Leonard
Details | Diff | Splinter Review
[PASSED QA] Bug 11386 - Mandatory fields in subscription add form should use standard formatting (9.45 KB, patch)
2014-03-13 15:48 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2013-12-11 20:25:59 UTC
The mandatory fields on the subscription add form are not highlighting when you miss to enter data in one. Also, they are using (*) instead of the standard formatting.
Comment 1 Julian Maurice 2013-12-18 11:26:17 UTC
Hi Katrin,

What is the "standard formatting" exactly? Text in red, followed by "Required" ?
What do you mean by "[they] are not highlighting when you miss to enter data" ? Is there a form in Koha that do that already ?
Comment 2 Katrin Fischer 2013-12-18 11:44:36 UTC
Hi Julian,

take a look at the administration > branches form. There is a newer Javascript library that can be used to achieve these things in Koha.
The bug is here: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6209

CCing Owen as the expert :)

There is another thing about the form that troubles me - the date fields are now readonly. This is an accessibility problem as not everyone is able to use the date plugin. Could you reconsider those? I think we have other examples that allow direct entry of dates. (I can file a separate bug later).
Comment 3 Julian Maurice 2013-12-19 09:51:40 UTC
> There is another thing about the form that troubles me - the date
> fields are now readonly. This is an accessibility problem as not
> everyone is able to use the date plugin. Could you reconsider those?
Do you mean this is a problem when Javascript is disabled? Is it OK if date fields are enabled by default, and then set readonly by Javascript ?
Comment 4 Katrin Fischer 2013-12-19 10:00:05 UTC
I think as Koha relies heavily on Javascript turning off Javascript is not an option, also modern tools seem to support it to some level. As I understood it the problem is that using the date widget with a screenreader or braille line is not possible - so typing in the date directly is what should be a valid alternative.
Comment 5 Julian Maurice 2013-12-19 11:08:40 UTC Comment hidden (obsolete)
Comment 6 Owen Leonard 2014-03-12 19:19:30 UTC Comment hidden (obsolete)
Comment 7 Katrin Fischer 2014-03-13 15:48:15 UTC
Created attachment 26312 [details] [review]
[PASSED QA] Bug 11386 - Mandatory fields in subscription add form should use standard formatting

Use jQuery.validate plugin for subscription add/edit form and remove
readonly attribute on date fields, as datepicker is not available for
everyone.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described, passes tests, and QA script.
Comment 8 Galen Charlton 2014-03-13 16:55:25 UTC
Pushed to master.  Thanks, Julian!